Thanks Ryan, Went for the option to create the quick fix and push it: - Pre-Commit tests are green - Only a single test is broken on non-UTC test runs - The fix is simple - straightforward
Here is the fix (https://github.com/apache/iceberg/pull/2283 <https://github.com/apache/iceberg/pull/2283>). After a green run I will pushed it and requested review for it. Thanks, Peter > On Feb 28, 2021, at 01:33, Ryan Blue <rb...@netflix.com.INVALID> wrote: > > If you think a commit broke something, then I think it's always okay to > revert it if needed. I also think it's okay to push a fix for it if you have > one and then make sure it's reviewed by other committers as soon as you can. > When in doubt, I'd probably go for the option to revert but it depends on the > situation. > > On Fri, Feb 26, 2021 at 11:45 PM Peter Vary <pv...@cloudera.com.invalid> > wrote: > Hi Team, > > Edgar Rodriguez reported, that my last change > (https://github.com/apache/iceberg/commit/23735d1d99abf0207543ff5d9dcb63ae4fe4ec02 > > <https://github.com/apache/iceberg/commit/23735d1d99abf0207543ff5d9dcb63ae4fe4ec02>) > is braking the test in non-UTC timezones. Probably fixed by another pending > change (https://github.com/apache/iceberg/pull/2278 > <https://github.com/apache/iceberg/pull/2278>), but that is not reviewed yet. > > What is the process of reverting a commit? > Created a pull request with the revert: > https://github.com/apache/iceberg/pull/2279 > <https://github.com/apache/iceberg/pull/2279>. Shall I wait for a review from > another committer, or can I just push it. > > Thanks, > Peter > > > > -- > Ryan Blue > Software Engineer > Netflix
