+1 for `iceberg-hive-metastore`. Maybe, is `Apache Iceberg 1.0.0` a good candidate to have that breaking change?
Bests, Dongjoon. On Wed, Aug 19, 2020 at 6:35 PM RD <rdsr...@gmail.com> wrote: > I'm +1 for this rename. I think we should keep the iceberg-mr module as > is and maybe add a new module iceberg-hive-exec [not sure if it is a good > idea to salvage iceberg-hive for this purpose] which contains hive specific > StorageHandler, Serde and IcebergHivInputFormat classes. > > -R > > On Wed, Aug 19, 2020 at 5:06 PM Ryan Blue <b...@apache.org> wrote: > >> In the discussion this morning, we talked about what to name the runtime >> module we want to add for Hive, iceberg-hive-runtime. Unfortunately, >> iceberg-hive is the Hive _metastore_ module, so it is a bit misleading to >> name the Hive runtime module iceberg-hive-runtime. It was also pointed out >> that the iceberg-hive module is confusing for other reasons: someone >> unfamiliar with it would expect to use it to work with Hive, but it has no >> InputFormat or StorageHandler classes. >> >> Both problems are a result of a poor name for iceberg-hive. Maybe we >> should rename iceberg-hive to iceberg-hive-metastore. >> >> The drawback is that a module people could use will disappear (I'm >> assuming we won't rename iceberg-mr to iceberg-hive right away). But most >> people probably use a runtime Jar, so it might be a good time to make this >> change before there are more people depending on it. >> >> What does everyone think? Should we do the rename? >> >> rb >> >> -- >> Ryan Blue >> >
