Yes, I merged them into our branches this afternoon and can confirm that the tests now pass. Thanks!
On Mon, 29 Jun 2020 at 19:24, Ryan Blue <rb...@netflix.com> wrote: > I merged this over the weekend, so it should be fixed now. Did it work for > you? > > On Fri, Jun 26, 2020 at 11:48 AM Mass Dosage <massdos...@gmail.com> wrote: > >> Cool, I look forward to trying it out 😀 >> >> On Fri, 26 Jun 2020, 18:56 Ryan Blue, <rb...@netflix.com.invalid> wrote: >> >>> Yes, I think Edgar has addressed this. I have it on my list of reviews >>> for today. >>> >>> On Fri, Jun 26, 2020 at 10:27 AM Edgar Rodriguez >>> <edgar.rodrig...@airbnb.com.invalid> wrote: >>> >>>> There's already a fix for this in >>>> https://github.com/apache/iceberg/pull/1127 >>>> >>>> Cheers, >>>> >>>> On Fri, Jun 26, 2020 at 5:26 AM Mass Dosage <massdos...@gmail.com> >>>> wrote: >>>> >>>>> Hello all, >>>>> >>>>> For the past week or so I've noticed failing builds on a local >>>>> checkout of master. >>>>> >>>>> I have raised an issue here: >>>>> >>>>> https://github.com/apache/iceberg/issues/1113 >>>>> >>>>> (there was initially one failing test, there are now two) >>>>> >>>>> Someone else raised a similar issue with one of the same failing tests >>>>> and then another one: >>>>> >>>>> https://github.com/apache/iceberg/issues/1116 >>>>> >>>>> What can we do in order to get these 3 failing tests resolved? I think >>>>> the first step should be to get the Travis build to fail on them so it's >>>>> clear to everyone that there is a problem here and a failing master build >>>>> should be #1 priority to resolve. Perhaps the Travis build could be >>>>> changed >>>>> to use a different timezone? I generally recommend using a timezone, >>>>> charset etc. in the CI system that is different to whatever most of the >>>>> developers have as their default in order to catch these kinds of issues. >>>>> >>>>> This is making it really hard to develop with confidence as one can't >>>>> tell whether failing tests are due to changes I am making or not. >>>>> >>>>> Thanks, >>>>> >>>>> Adrian >>>>> >>>> >>>> >>>> -- >>>> Edgar R >>>> >>> >>> >>> -- >>> Ryan Blue >>> Software Engineer >>> Netflix >>> >> > > -- > Ryan Blue > Software Engineer > Netflix >
