+1 (non-binding) Validated checksums and signature, ran ./gradlew build, and ran license check.
Loaded into a downstream project and it worked as expected. Best, Ryan On Wed, Apr 29, 2020 at 5:26 AM tison <wander4...@gmail.com> wrote: > Hi Ryan, > > Thanks for starting the voting process. > > +1 (non-binding) I verified: > > √ RAT checks passed > √ signature is correct > √ checksum is correct > √ build from source > √ run tests locally > > I'd like to ask 2 questions: > > 1. The verify flow above is very clear, shall we have a page under > https://iceberg.apache.org/ project tag document it? > 2. Given it is a voting phase for the release, what if we have a pending > PR for the updates of website(https://iceberg.apache.org/releases/) so > that we can verify it in this phase also. > > Best, > tison. > > > Ryan Blue <b...@apache.org> 于2020年4月29日周三 上午8:37写道: > >> +1 (binding) >> >> Validated checksums and signature, ran ./gradlew check, and ran license >> check. >> >> I also downloaded Spark 2.4.5 and loaded iceberg-spark-runtime like this: >> >> spark-2.4.5-bin-hadoop2.7/bin/spark-shell \ >> --conf >> spark.jars.repositories=https://repository.apache.org/content/repositories/orgapacheiceberg-1005/ >> \ >> --packages org.apache.iceberg:iceberg-spark-runtime:0.8.0-incubating \ >> --conf spark.sql.warehouse.dir=/home/blue/tmp/spark-warehouse \ >> --conf spark.hadoop.hive.metastore.uris=thrift://localhost:45655 >> >> I spot-checked Hive writes, overwrites, metadata tables, and >> input_file_name(). >> >> By the way, to run a metastore, I just started one of the Iceberg Hive >> metastore tests with an infinite loop and added a print statement to get >> the thrift URI. That’s an easy way to create one. >> >> On Tue, Apr 28, 2020 at 1:44 PM Ryan Blue <b...@apache.org> wrote: >> >>> Here are the steps to verify the release that I sent out last time, for >>> anyone that doesn’t want to look them up: >>> >>> 1. Download the source tarball, signature (.asc), and checksum >>> (.sha512) from >>> >>> https://dist.apache.org/repos/dist/dev/incubator/iceberg/apache-iceberg-0.8.0-incubating-rc1/ >>> 2. Import gpg keys: download KEYS and run gpg --import >>> /path/to/downloaded/KEYS (optional if this hasn’t changed) >>> 3. Verify the signature by running: gpg --verify >>> apache-iceberg-0.8.0-incubating.tar.gz.asc >>> 4. Verify the checksum by running: sha512sum -c >>> apache-iceberg-0.8.0-incubating.tar.gz.sha512 >>> 5. Untar the archive and go into the source directory: tar xzf >>> apache-iceberg-0.8.0-incubating.tar.gz && cd >>> apache-iceberg-0.8.0-incubating >>> 6. Run RAT checks to validate license headers: dev/check-license >>> 7. Build and test the project: ./gradlew build (use Java 8) >>> >>> You can also validate the LICENSE and NOTICE documentation, which is >>> included in the source tarball, as well as the staged binary artifacts. The >>> latest update to the spark-runtime Jar’s was PR #966 >>> <https://github.com/apache/incubator-iceberg/pull/966> if you’d like to >>> review it. >>> >>> To validate the convenience binaries, add the Maven URL from the email >>> above to a downstream project and update your Iceberg dependency to >>> 0.8.0-incubating, like this: >>> >>> repositories { >>> maven { >>> name 'stagedIceberg' >>> url >>> 'https://repository.apache.org/content/repositories/orgapacheiceberg-1005/' >>> } >>> } >>> >>> ext { >>> icebergVersion = '0.8.0-incubating' >>> } >>> >>> Then run the downstream project’s tests. >>> >>> Thanks for reviewing and voting, everyone! >>> >>> rb >>> >>> On Tue, Apr 28, 2020 at 1:39 PM Ryan Blue <b...@apache.org> wrote: >>> >>>> Hi everyone, >>>> >>>> I propose the following RC to be released as official Apache Iceberg >>>> 0.8.0-incubating release. >>>> >>>> The commit id is 4c2dd0ac2c832cc425b33d3b578025fa4e295392 >>>> * This corresponds to the tag: apache-iceberg-0.8.0-incubating-rc1 >>>> * >>>> https://github.com/apache/incubator-iceberg/commits/apache-iceberg-0.8.0-incubating-rc1 >>>> * https://github.com/apache/incubator-iceberg/tree/4c2dd0ac >>>> >>>> The release tarball, signature, and checksums are here: >>>> * >>>> https://dist.apache.org/repos/dist/dev/incubator/iceberg/apache-iceberg-0.8.0-incubating-rc1/ >>>> >>>> You can find the KEYS file here: >>>> * https://dist.apache.org/repos/dist/dev/incubator/iceberg/KEYS >>>> >>>> Convenience binary artifacts are staged in Nexus. The Maven repository >>>> URL is: >>>> * >>>> https://repository.apache.org/content/repositories/orgapacheiceberg-1005/ >>>> >>>> This release contains many bug fixes and several new features: >>>> * Actions to remove orphaned files and to optimize metadata for query >>>> performance >>>> * Support for ORC data files >>>> * Snapshot cherry-picking >>>> * Incremental scan planning based on table history >>>> * In and notIn expressions >>>> * An InputFormat for writing MR jobs >>>> >>>> Please download, verify, and test. >>>> >>>> Please vote in the next 72 hours. >>>> >>>> [ ] +1 Release this as Apache Iceberg 0.8.0-incubating >>>> [ ] +0 >>>> [ ] -1 Do not release this because... >>>> >>>> >>>> -- >>>> Ryan Blue >>>> >>> >>> >>> -- >>> Ryan Blue >>> >> >> >> -- >> Ryan Blue >> >