Sounds fine to me. Can you open a PR for this? On Wed, Feb 19, 2020 at 11:40 AM Vlad Rozov <vro...@apache.org> wrote:
> Hi Ryan, > > Currently, it is a cherry-pick of classes from org.apache.iceberg and few > other packages likely based on minimizing existing static imports plus all > tests being excluded from the avoid static import rule. I'd suggest > removing all exceptions from the rule and prohibiting static import for all > packages/classes. Test classes and a few classes that extensively use > static import can be added to the rule suppression list. > > Thank you, > > Vlad > > On 2020/02/19 18:55:38, Ryan Blue <rb...@netflix.com.INVALID> wrote: > > Hi Vlad, > > > > What is the current rule? What do you think we should change it to and > why > > is that a good idea? > > > > On Tue, Feb 18, 2020 at 3:54 PM Vlad Rozov <vro...@apache.org> wrote: > > > > > Hi, > > > > > > Should static imports be prohibited for all packages or > > > “org.apache.iceberg.*” should be excluded from the avoid static imports > > > rule? > > > > > > Thank you, > > > > > > Vlad > > > > > > > > -- > > Ryan Blue > > Software Engineer > > Netflix > > > -- Ryan Blue Software Engineer Netflix
