Thanks James! The LICENSE and NOTICE in the runtime Jar are updated for the shaded dependencies. For NOTICE, only Airlift and ORC had notice file contents that needed to be included. For LICENSE, there are quite a few additional entries for the shaded Jars. You can find more detail on the PR: https://github.com/apache/incubator-iceberg/pull/356
rb On Tue, Oct 22, 2019 at 12:37 PM James Taylor <jamestay...@apache.org> wrote: > Belated +1 from me (will vote on incubator vote once started). I > successfully downloaded, verified license, verified checksum, verified > signature, built from source, and ran unit tests. > > I have similar questions as Jacques about the binary release. I think you > may need a top level LICENSE and NOTICE file that is a concatenation of the > LICENSE and NOTICE files of the transitive closure of dependencies. I > haven't had to deal with this in quite a while, though, so I may be off > here. Justin Mclean is very knowledgeable in this area. FWIW, most > incubator projects don't attempt a binary release as part of their first > release. > > On Tue, Oct 22, 2019 at 9:19 AM Ryan Blue <b...@apache.org> wrote: > >> With +1 votes and no +0 or -1 votes, this candidate passes. >> >> +1 votes: >> John Zhuge >> *Anton Okolnychyi >> Junjie Chen >> David Christle >> Thippana Vamsi Kalyan >> *Ryan Blue >> *Daniel Weeks >> *Parth Brahmbhatt >> >> *=binding PPMC vote >> >> The next step is to start a thread on the IPMC list. While in incubation, >> our releases are a two-stage process where the podling PMC validates and >> then the incubator PMC double-checks the result. >> >> rb >> >> On Fri, Oct 18, 2019 at 5:13 PM Ryan Blue <b...@apache.org> wrote: >> >>> Hi everyone, >>> >>> I propose the following RC to be released as official Apache Iceberg >>> 0.7.0-incubating release. >>> >>> The commit id is 9c81babac65351f7aa21dd878f01c5c81ae304af >>> * This corresponds to the tag: apache-iceberg-0.7.0-incubating-rc4 >>> * >>> https://github.com/apache/incubator-iceberg/tree/apache-iceberg-0.7.0-incubating-rc4 >>> * >>> https://github.com/apache/incubator-iceberg/tree/9c81babac65351f7aa21dd878f01c5c81ae304af >>> >>> The release tarball, signature, and checksums are here: >>> * >>> https://dist.apache.org/repos/dist/dev/incubator/iceberg/apache-iceberg-0.7.0-incubating-rc4/ >>> >>> You can find the KEYS file here: >>> * https://dist.apache.org/repos/dist/dev/incubator/iceberg/KEYS >>> >>> Convenience binary artifacts are staged in Nexus. The Maven repository >>> URL is: >>> * >>> https://repository.apache.org/content/repositories/orgapacheiceberg-1004/ >>> >>> This is the first Apache Iceberg release. >>> >>> Please download, verify, and test; then vote in the next 72 hours. >>> >>> [ ] +1 Release this as Apache Iceberg 0.7.0-incubating >>> [ ] +0 >>> [ ] -1 Do not release this because... >>> >>> -- >>> Ryan Blue >>> >> >> >> -- >> Ryan Blue >> > -- Ryan Blue Software Engineer Netflix
