rdblue commented on issue #15: Allow FileSystem provision to be overridden.
URL: https://github.com/apache/incubator-iceberg/pull/15#issuecomment-442183487
 
 
   I don't think that `FileIO` should handle other operations like `rename`. We 
could add `exists` to `InputFile` and `OutputFile`.
   
   This is the only use of `rename` in the project. It is used to ensure that 
metadata commits are atomic when the underlying file system supports atomic 
rename. Since that's required for this class, then I think we should go ahead 
with this PR and add `FileIO` separately.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to