----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26255/#review55596 -----------------------------------------------------------
service/src/java/org/apache/hive/service/server/HiveServer2.java <https://reviews.apache.org/r/26255/#comment95964> should be "Error deregistering HiveServer2" service/src/java/org/apache/hive/service/server/HiveServer2.java <https://reviews.apache.org/r/26255/#comment95963> It would be useful to be able to modify configuration before actions are done. ie, the iteration on confProps should happen first. - Thejas Nair On Oct. 6, 2014, 10:21 p.m., Vaibhav Gumashta wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26255/ > ----------------------------------------------------------- > > (Updated Oct. 6, 2014, 10:21 p.m.) > > > Review request for hive and Thejas Nair. > > > Bugs: HIVE-8288 > https://issues.apache.org/jira/browse/HIVE-8288 > > > Repository: hive-git > > > Description > ------- > > https://issues.apache.org/jira/browse/HIVE-8288 > > > Diffs > ----- > > bin/ext/hiveserver2.cmd dc3bba3 > bin/ext/hiveserver2.sh 45d7893 > service/src/java/org/apache/hive/service/server/HiveServer2.java c667533 > service/src/java/org/apache/hive/service/server/ServerOptionsProcessor.java > bbb2a42 > > service/src/test/org/apache/hive/service/server/TestServerOptionsProcessor.java > 1aea0b8 > > Diff: https://reviews.apache.org/r/26255/diff/ > > > Testing > ------- > > Manually with multiple HS2 instances. > > > Thanks, > > Vaibhav Gumashta > >