> On Oct. 2, 2014, 10:54 p.m., Thejas Nair wrote: > > service/src/java/org/apache/hive/service/server/HiveServer2.java, line 296 > > <https://reviews.apache.org/r/26255/diff/1/?file=710399#file710399line296> > > > > how about looking for: "version=" + versionNumber + ";" ?
Will do > On Oct. 2, 2014, 10:54 p.m., Thejas Nair wrote: > > service/src/java/org/apache/hive/service/server/HiveServer2.java, line 317 > > <https://reviews.apache.org/r/26255/diff/1/?file=710399#file710399line317> > > > > It would be good to print hte old "Starting HiveServer2" message here Sorry, I intended to remove it from the script and move it in here. Will do > On Oct. 2, 2014, 10:54 p.m., Thejas Nair wrote: > > service/src/java/org/apache/hive/service/server/ServerOptionsProcessor.java, > > line 78 > > <https://reviews.apache.org/r/26255/diff/1/?file=710400#file710400line78> > > > > I feel it is unintuitive to perform actions in the OptionsProcessor. > > How about returning the action information in > > ServerOptionsProcessorResponse and performing the action via HiveServer2 > > class. > > > > That way we can also make use of the log4j logs Let me look at this. > On Oct. 2, 2014, 10:54 p.m., Thejas Nair wrote: > > service/src/java/org/apache/hive/service/server/ServerOptionsProcessor.java, > > line 82 > > <https://reviews.apache.org/r/26255/diff/1/?file=710400#file710400line82> > > > > once this is moved to post options processing, we should use log4j and > > log the full exception (log.error(e.getMessage, e); Sure, will do. - Vaibhav ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26255/#review55262 ----------------------------------------------------------- On Oct. 2, 2014, 1:13 a.m., Vaibhav Gumashta wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26255/ > ----------------------------------------------------------- > > (Updated Oct. 2, 2014, 1:13 a.m.) > > > Review request for hive and Thejas Nair. > > > Bugs: HIVE-8288 > https://issues.apache.org/jira/browse/HIVE-8288 > > > Repository: hive-git > > > Description > ------- > > https://issues.apache.org/jira/browse/HIVE-8288 > > > Diffs > ----- > > bin/ext/hiveserver2.cmd a5f3bb5 > bin/ext/hiveserver2.sh 45d7893 > service/src/java/org/apache/hive/service/server/HiveServer2.java c667533 > service/src/java/org/apache/hive/service/server/ServerOptionsProcessor.java > bbb2a42 > > service/src/test/org/apache/hive/service/server/TestServerOptionsProcessor.java > 1aea0b8 > > Diff: https://reviews.apache.org/r/26255/diff/ > > > Testing > ------- > > Manually with multiple HS2 instances. > > > Thanks, > > Vaibhav Gumashta > >
