> On Sept. 19, 2014, 8:52 p.m., Brock Noland wrote: > > jdbc/src/java/org/apache/hive/jdbc/HiveStatement.java, line 768 > > <https://reviews.apache.org/r/25575/diff/5/?file=694551#file694551line768> > > > > if ( not null) { > > > > } else { > > > > > > is simpler as: > > > > if (null) { > > > > } else {
I think it is better to put the valid common case at first, like Thejas metioned in below comments. Shall we keep the order here? - Dong ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25575/#review54023 ----------------------------------------------------------- On Sept. 24, 2014, 9:17 a.m., Dong Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25575/ > ----------------------------------------------------------- > > (Updated Sept. 24, 2014, 9:17 a.m.) > > > Review request for hive. > > > Repository: hive-git > > > Description > ------- > > When executing query in Beeline, user should have a option to see the > progress through the outputs. Beeline could use the API introduced in > HIVE-4629 to get and display the logs to the client. > > > Diffs > ----- > > beeline/pom.xml 45fa02b > beeline/src/java/org/apache/hive/beeline/Commands.java a92d69f > > itests/hive-unit/src/test/java/org/apache/hive/beeline/TestBeeLineWithArgs.java > 1e66542 > itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestJdbcDriver2.java > daf8e9e > jdbc/src/java/org/apache/hive/jdbc/ClosedOrCancelledStatementException.java > PRE-CREATION > jdbc/src/java/org/apache/hive/jdbc/HiveQueryResultSet.java 86bc580 > jdbc/src/java/org/apache/hive/jdbc/HiveStatement.java 2cbf58c > > Diff: https://reviews.apache.org/r/25575/diff/ > > > Testing > ------- > > UT passed. > > > Thanks, > > Dong Chen > >
