----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25575/#review53809 -----------------------------------------------------------
itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestJdbcDriver2.java <https://reviews.apache.org/r/25575/#comment93627> We can keep the logic here (and any other application using getQueryLog method) simpler by checking the query status (running or not) within statement.getQueryLog, instead of doing it here. That way we can keep the method get state of HiveStatement a private api. I don't think we need this timeout loop. As long as execute call hasn't returned we won't be able to make any calls to get log because of the transportLock. jdbc/src/java/org/apache/hive/jdbc/HiveStatement.java <https://reviews.apache.org/r/25575/#comment93624> Looks like we just need to check isRunning (ie true or false) for running. We don't need the whole set of enums, and complexity associated with getting those values right. Can we just use a boolean instead of the enum ? Apart from complexity, the reason for using boolean instead of enum - I am also concerned about people starting to use these enums and then complain if we change them in future. Even though we haven't documented it as a public api, people might start using them. So keeping the functionality we promise through methods here to minimal is safer. jdbc/src/java/org/apache/hive/jdbc/HiveStatement.java <https://reviews.apache.org/r/25575/#comment93625> set isRunning=true here and set isRunning=false in other place of other calls to setQueryStatus - Thejas Nair On Sept. 18, 2014, 6:30 a.m., Dong Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25575/ > ----------------------------------------------------------- > > (Updated Sept. 18, 2014, 6:30 a.m.) > > > Review request for hive. > > > Repository: hive-git > > > Description > ------- > > When executing query in Beeline, user should have a option to see the > progress through the outputs. Beeline could use the API introduced in > HIVE-4629 to get and display the logs to the client. > > > Diffs > ----- > > beeline/pom.xml 45fa02b > beeline/src/java/org/apache/hive/beeline/Commands.java a92d69f > > itests/hive-unit/src/test/java/org/apache/hive/beeline/TestBeeLineWithArgs.java > e1d44ec > itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestJdbcDriver2.java > ae128a9 > jdbc/src/java/org/apache/hive/jdbc/HiveStatement.java 2cbf58c > > Diff: https://reviews.apache.org/r/25575/diff/ > > > Testing > ------- > > UT passed. > > > Thanks, > > Dong Chen > >
