----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15449/#review51654 -----------------------------------------------------------
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java <https://reviews.apache.org/r/15449/#comment90160> Some of these lines are too long common/src/java/org/apache/hadoop/hive/conf/HiveConf.java <https://reviews.apache.org/r/15449/#comment90161> I suggest changing to "setting to zero or negative value." common/src/java/org/apache/hadoop/hive/conf/HiveConf.java <https://reviews.apache.org/r/15449/#comment90162> I suggest adding spaces between the elements of the enumeration to make it easier to read common/src/java/org/apache/hadoop/hive/conf/Validator.java <https://reviews.apache.org/r/15449/#comment90163> public static is redundant for interface members itests/hive-unit/src/test/java/org/apache/hive/jdbc/miniHS2/TestHiveServer2SessionTimeout.java <https://reviews.apache.org/r/15449/#comment90164> assertTrue can be replaced with fail() instead to make the error message clearer itests/hive-unit/src/test/java/org/apache/hive/jdbc/miniHS2/TestHiveServer2SessionTimeout.java <https://reviews.apache.org/r/15449/#comment90165> long line service/src/java/org/apache/hive/service/cli/OperationState.java <https://reviews.apache.org/r/15449/#comment90166> private is redundant for enum constructors service/src/java/org/apache/hive/service/cli/operation/Operation.java <https://reviews.apache.org/r/15449/#comment90167> no need to call the accessor, you can replace it just with lastAccessTime service/src/java/org/apache/hive/service/cli/session/HiveSession.java <https://reviews.apache.org/r/15449/#comment90168> public keyword is redundant in interfaces service/src/java/org/apache/hive/service/cli/session/HiveSessionBase.java <https://reviews.apache.org/r/15449/#comment90169> public keyword is redundant in interfaces service/src/java/org/apache/hive/service/cli/session/HiveSessionImpl.java <https://reviews.apache.org/r/15449/#comment90171> Missing @Override annotation service/src/java/org/apache/hive/service/cli/session/HiveSessionImpl.java <https://reviews.apache.org/r/15449/#comment90170> Assignments to longs are not atomic. You could ignore this, make lastAccessTime volatile or getLastAccessTime synchronized. http://docs.oracle.com/javase/specs/jls/se8/html/jls-17.html#jls-17.7 service/src/java/org/apache/hive/service/cli/session/HiveSessionImpl.java <https://reviews.apache.org/r/15449/#comment90172> You can replace this with OperationHandle[] handles = opHandleSet.toArray(new OperationHandle[opHandleSet.size()]); to immediately create the proper sized array service/src/java/org/apache/hive/service/cli/session/SessionManager.java <https://reviews.apache.org/r/15449/#comment90173> Hmm... this minimum should be documented in HiveConf and probably moved out to a constant. What's the reason for this minimum? service/src/java/org/apache/hive/service/cli/session/SessionManager.java <https://reviews.apache.org/r/15449/#comment90174> Missing @Override Mostly minor code style comments. - Lars Francke On Aug. 27, 2014, 8:05 a.m., Navis Ryu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15449/ > ----------------------------------------------------------- > > (Updated Aug. 27, 2014, 8:05 a.m.) > > > Review request for hive. > > > Bugs: HIVE-5799 > https://issues.apache.org/jira/browse/HIVE-5799 > > > Repository: hive-git > > > Description > ------- > > Need some timeout facility for preventing resource leakages from instable or > bad clients. > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 7f4afd9 > common/src/java/org/apache/hadoop/hive/conf/Validator.java cea9c41 > > itests/hive-unit/src/test/java/org/apache/hive/jdbc/miniHS2/TestHiveServer2SessionTimeout.java > PRE-CREATION > service/src/java/org/apache/hive/service/cli/OperationState.java 3e15f0c > service/src/java/org/apache/hive/service/cli/operation/Operation.java > 45fbd61 > > service/src/java/org/apache/hive/service/cli/operation/OperationManager.java > 21c33bc > service/src/java/org/apache/hive/service/cli/session/HiveSession.java > 9785e95 > service/src/java/org/apache/hive/service/cli/session/HiveSessionBase.java > eee1cc6 > service/src/java/org/apache/hive/service/cli/session/HiveSessionImpl.java > bc0a02c > > service/src/java/org/apache/hive/service/cli/session/HiveSessionImplwithUGI.java > 39d2184 > service/src/java/org/apache/hive/service/cli/session/SessionManager.java > d573592 > > Diff: https://reviews.apache.org/r/15449/diff/ > > > Testing > ------- > > Confirmed in the local environment. > > > Thanks, > > Navis Ryu > >
