----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15449/#review51637 -----------------------------------------------------------
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java <https://reviews.apache.org/r/15449/#comment90124> Just curious: for all 3 parameters, if the units are msec by default (as hive-default.xml.template said) then why are the default values shown as "0s" -- doesn't that mean 0 seconds, or is "s" something else? common/src/java/org/apache/hadoop/hive/conf/HiveConf.java <https://reviews.apache.org/r/15449/#comment90121> The parameter description needs the time unit information that used to be in hive-default.xml.template: "Accepts a numeric value which is msec by default but also can be used with other time units appended (sec, min, hour, day)." common/src/java/org/apache/hadoop/hive/conf/HiveConf.java <https://reviews.apache.org/r/15449/#comment90122> Description needs unit information that was in hive-default.xml.template: "Accepts a numeric value which is msec by default but also can be used with other time units appended (sec, min, hour, day)." common/src/java/org/apache/hadoop/hive/conf/HiveConf.java <https://reviews.apache.org/r/15449/#comment90123> Description needs unit information that was in hive-default.xml.template: "Accepts a numeric value which is msec by default but also can be used with other time units appended (sec, min, hour, day)." - Lefty Leverenz On Aug. 27, 2014, 4:42 a.m., Navis Ryu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15449/ > ----------------------------------------------------------- > > (Updated Aug. 27, 2014, 4:42 a.m.) > > > Review request for hive. > > > Bugs: HIVE-5799 > https://issues.apache.org/jira/browse/HIVE-5799 > > > Repository: hive-git > > > Description > ------- > > Need some timeout facility for preventing resource leakages from instable or > bad clients. > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 7f4afd9 > common/src/java/org/apache/hadoop/hive/conf/Validator.java cea9c41 > > itests/hive-unit/src/test/java/org/apache/hive/jdbc/miniHS2/TestHiveServer2SessionTimeout.java > PRE-CREATION > service/src/java/org/apache/hive/service/cli/OperationState.java 3e15f0c > service/src/java/org/apache/hive/service/cli/operation/Operation.java > 45fbd61 > > service/src/java/org/apache/hive/service/cli/operation/OperationManager.java > 21c33bc > service/src/java/org/apache/hive/service/cli/session/HiveSession.java > 9785e95 > service/src/java/org/apache/hive/service/cli/session/HiveSessionBase.java > eee1cc6 > service/src/java/org/apache/hive/service/cli/session/HiveSessionImpl.java > bc0a02c > > service/src/java/org/apache/hive/service/cli/session/HiveSessionImplwithUGI.java > 39d2184 > service/src/java/org/apache/hive/service/cli/session/SessionManager.java > d573592 > > Diff: https://reviews.apache.org/r/15449/diff/ > > > Testing > ------- > > Confirmed in the local environment. > > > Thanks, > > Navis Ryu > >
