----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24498/#review51109 -----------------------------------------------------------
Patch does a great job of making # of queries independent of # of columns. Good work! But it seems its now making queries over all partitions of table, instead of those listed in request. metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java <https://reviews.apache.org/r/24498/#comment89121> Now that you have fixed this TODO, you can delete it. metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java <https://reviews.apache.org/r/24498/#comment89114> This should contain " and PARTITION_NAME in ()" otherwise we are running query over all partitions of table, instead of those requested. metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java <https://reviews.apache.org/r/24498/#comment89117> This should contain " and PARTITION_NAME in ()" otherwise we are running query over all partitions of table, instead of those requested. metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java <https://reviews.apache.org/r/24498/#comment89118> This should contain " and PARTITION_NAME in ()" otherwise we are running query over all partitions of table, instead of those requested. - Ashutosh Chauhan On Aug. 20, 2014, 6:52 a.m., pengcheng xiong wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24498/ > ----------------------------------------------------------- > > (Updated Aug. 20, 2014, 6:52 a.m.) > > > Review request for hive. > > > Repository: hive-git > > > Description > ------- > > We propose a method to extrapolate the missing column status for the > partitions. > > > Diffs > ----- > > data/files/extrapolate_stats_full.txt PRE-CREATION > data/files/extrapolate_stats_partial.txt PRE-CREATION > metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java > 84ef5f9 > > metastore/src/java/org/apache/hadoop/hive/metastore/IExtrapolatePartStatus.java > PRE-CREATION > > metastore/src/java/org/apache/hadoop/hive/metastore/LinearExtrapolatePartStatus.java > PRE-CREATION > metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java > 767cffc > metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java > a9f4be2 > metastore/src/java/org/apache/hadoop/hive/metastore/RawStore.java 0364385 > > metastore/src/test/org/apache/hadoop/hive/metastore/DummyRawStoreControlledCommit.java > 4eba2b0 > > metastore/src/test/org/apache/hadoop/hive/metastore/DummyRawStoreForJdoConnection.java > 78ab19a > ql/src/test/queries/clientpositive/extrapolate_part_stats_full.q > PRE-CREATION > ql/src/test/queries/clientpositive/extrapolate_part_stats_partial.q > PRE-CREATION > ql/src/test/results/clientpositive/extrapolate_part_stats_full.q.out > PRE-CREATION > ql/src/test/results/clientpositive/extrapolate_part_stats_partial.q.out > PRE-CREATION > > Diff: https://reviews.apache.org/r/24498/diff/ > > > Testing > ------- > > > File Attachments > ---------------- > > HIVE-7654.0.patch > > https://reviews.apache.org/media/uploaded/files/2014/08/12/77b155b0-a417-4225-b6b7-4c8c6ce2b97d__HIVE-7654.0.patch > > > Thanks, > > pengcheng xiong > >
