> On Aug. 13, 2014, 1:10 a.m., Sergey Shelukhin wrote: > > metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java, > > line 1101 > > <https://reviews.apache.org/r/24498/diff/2/?file=658642#file658642line1101> > > > > please quote the identifier names (won't work on pgsql otherwise) and > > use parameters for parameters > > pengcheng xiong wrote: > Sorry, could you please give an example of "use parameters for > parameters"? Thanks!
See many other queries where "?"s are used w/parameters array (in the same file) - Sergey ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24498/#review50392 ----------------------------------------------------------- On Aug. 17, 2014, 4:23 a.m., pengcheng xiong wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24498/ > ----------------------------------------------------------- > > (Updated Aug. 17, 2014, 4:23 a.m.) > > > Review request for hive. > > > Repository: hive-git > > > Description > ------- > > We propose a method to extrapolate the missing column status for the > partitions. > > > Diffs > ----- > > > metastore/src/java/org/apache/hadoop/hive/metastore/IExtrapolatePartStatus.java > PRE-CREATION > > metastore/src/java/org/apache/hadoop/hive/metastore/LinearExtrapolatePartStatus.java > PRE-CREATION > metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java > 767cffc > ql/src/test/queries/clientpositive/extrapolate_part_stats.q PRE-CREATION > ql/src/test/results/clientpositive/extrapolate_part_stats.q.out > PRE-CREATION > > Diff: https://reviews.apache.org/r/24498/diff/ > > > Testing > ------- > > > File Attachments > ---------------- > > HIVE-7654.0.patch > > https://reviews.apache.org/media/uploaded/files/2014/08/12/77b155b0-a417-4225-b6b7-4c8c6ce2b97d__HIVE-7654.0.patch > > > Thanks, > > pengcheng xiong > >
