[ 
https://issues.apache.org/jira/browse/HIVE-7286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14071146#comment-14071146
 ] 

David Chen commented on HIVE-7286:
----------------------------------

Thanks for reviewing this patch, [~szehon]. I have removed the reflection code. 
The fixture is now testing against the set of native storage formats and the 
ones specified in additional storage formats list in the test since the native 
storage formats are regarded as the "official" and most complete storage 
formats supported by Hive.

I will open another ticket to add documentation about this to the Wiki.

> Parameterize HCatMapReduceTest for testing against all Hive storage formats
> ---------------------------------------------------------------------------
>
>                 Key: HIVE-7286
>                 URL: https://issues.apache.org/jira/browse/HIVE-7286
>             Project: Hive
>          Issue Type: Sub-task
>          Components: HCatalog
>            Reporter: David Chen
>            Assignee: David Chen
>         Attachments: HIVE-7286.1.patch, HIVE-7286.2.patch, HIVE-7286.3.patch, 
> HIVE-7286.4.patch, HIVE-7286.5.patch, HIVE-7286.6.patch
>
>
> Currently, HCatMapReduceTest, which is extended by the following test suites:
>  * TestHCatDynamicPartitioned
>  * TestHCatNonPartitioned
>  * TestHCatPartitioned
>  * TestHCatExternalDynamicPartitioned
>  * TestHCatExternalNonPartitioned
>  * TestHCatExternalPartitioned
>  * TestHCatMutableDynamicPartitioned
>  * TestHCatMutableNonPartitioned
>  * TestHCatMutablePartitioned
> These tests run against RCFile. Currently, only TestHCatDynamicPartitioned is 
> run against any other storage format (ORC).
> Ideally, HCatalog should be tested against all storage formats supported by 
> Hive. The easiest way to accomplish this is to turn HCatMapReduceTest into a 
> parameterized test fixture that enumerates all Hive storage formats. Until 
> HIVE-5976 is implemented, we would need to manually create the mapping of 
> SerDe to InputFormat and OutputFormat. This way, we can explicitly keep track 
> of which storage formats currently work with HCatalog or which ones are 
> untested or have test failures. The test fixture should also use Reflection 
> to find all classes in the classpath that implements the SerDe interface and 
> raise a failure if any of them are not enumerated.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to