----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23404/#review47797 -----------------------------------------------------------
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java <https://reviews.apache.org/r/23404/#comment84003> nit, space after "," ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/NullScanOptimizer.java <https://reviews.apache.org/r/23404/#comment84002> can you add a condition here for limit 0? that way we handle nested limit 0 as well. ql/src/test/queries/clientpositive/optimize_nullscan.q <https://reviews.apache.org/r/23404/#comment84001> can you add tests that filter after a union or join? the reason is I want to make sure we propagate to all table scans above the null filter (select * from (... union ... join) where false; - Gunther Hagleitner On July 10, 2014, 11:25 p.m., Ashutosh Chauhan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/23404/ > ----------------------------------------------------------- > > (Updated July 10, 2014, 11:25 p.m.) > > > Review request for hive. > > > Bugs: HIVE-7385 > https://issues.apache.org/jira/browse/HIVE-7385 > > > Repository: hive-git > > > Description > ------- > > Optimize for empty relation scans > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 8bff2a9 > itests/qtest/testconfiguration.properties f074b8e > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/MetadataOnlyOptimizer.java > 5bad2e5 > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/MetadataOnlyTaskDispatcher.java > PRE-CREATION > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/NullScanOptimizer.java > PRE-CREATION > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/PhysicalOptimizer.java > cf049b2 > ql/src/test/queries/clientpositive/optimize_nullscan.q PRE-CREATION > ql/src/test/results/clientpositive/optimize_nullscan.q.out PRE-CREATION > ql/src/test/results/clientpositive/tez/optimize_nullscan.q.out PRE-CREATION > > Diff: https://reviews.apache.org/r/23404/diff/ > > > Testing > ------- > > added new tests. > > > Thanks, > > Ashutosh Chauhan > >
