-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23404/#review47795
-----------------------------------------------------------



ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/PhysicalOptimizer.java
<https://reviews.apache.org/r/23404/#comment83999>

    i think you need to add a similar statement to TezCompiler to enable it 
there as well.



ql/src/test/results/clientpositive/optimize_nullscan.q.out
<https://reviews.apache.org/r/23404/#comment83998>

    the explain plan doesn't actually show whether the opt kicked in or not. 
extended might (because it's printing the file format used.)


- Gunther Hagleitner


On July 10, 2014, 11:25 p.m., Ashutosh Chauhan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23404/
> -----------------------------------------------------------
> 
> (Updated July 10, 2014, 11:25 p.m.)
> 
> 
> Review request for hive.
> 
> 
> Bugs: HIVE-7385
>     https://issues.apache.org/jira/browse/HIVE-7385
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> Optimize for empty relation scans
> 
> 
> Diffs
> -----
> 
>   common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 8bff2a9 
>   itests/qtest/testconfiguration.properties f074b8e 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/MetadataOnlyOptimizer.java
>  5bad2e5 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/MetadataOnlyTaskDispatcher.java
>  PRE-CREATION 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/NullScanOptimizer.java
>  PRE-CREATION 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/PhysicalOptimizer.java
>  cf049b2 
>   ql/src/test/queries/clientpositive/optimize_nullscan.q PRE-CREATION 
>   ql/src/test/results/clientpositive/optimize_nullscan.q.out PRE-CREATION 
>   ql/src/test/results/clientpositive/tez/optimize_nullscan.q.out PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/23404/diff/
> 
> 
> Testing
> -------
> 
> added new tests.
> 
> 
> Thanks,
> 
> Ashutosh Chauhan
> 
>

Reply via email to