[ https://issues.apache.org/jira/browse/HIVE-7201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14031781#comment-14031781 ]
Hive QA commented on HIVE-7201: ------------------------------- {color:red}Overall{color}: -1 no tests executed Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12650163/HIVE-7201.03.patch Test results: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-Build/468/testReport Console output: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-Build/468/console Test logs: http://ec2-174-129-184-35.compute-1.amazonaws.com/logs/PreCommit-HIVE-Build-468/ Messages: {noformat} **** This message was trimmed, see log for full details **** Reverted 'ql/src/test/results/clientpositive/bucketmapjoin11.q.out' Reverted 'ql/src/test/results/clientpositive/join26.q.out' Reverted 'ql/src/test/results/clientpositive/bucketmapjoin_negative.q.out' Reverted 'ql/src/test/results/clientpositive/union34.q.out' Reverted 'ql/src/test/results/clientpositive/join12.q.out' Reverted 'ql/src/test/results/clientpositive/smb_mapjoin_16.q.out' Reverted 'ql/src/test/results/clientpositive/ppd_join_filter.q.out' Reverted 'ql/src/test/results/clientpositive/join35.q.out' Reverted 'ql/src/test/results/clientpositive/bucketmapjoin2.q.out' Reverted 'ql/src/test/results/clientpositive/mapjoin_subquery2.q.out' Reverted 'ql/src/test/results/clientpositive/union20.q.out' Reverted 'ql/src/test/results/clientpositive/correlationoptimizer15.q.out' Reverted 'ql/src/test/results/clientpositive/column_access_stats.q.out' Reverted 'ql/src/test/results/clientpositive/smb_mapjoin_25.q.out' Reverted 'ql/src/test/results/clientpositive/join_map_ppr.q.out' Reverted 'ql/src/test/results/clientpositive/ppd_multi_insert.q.out' Reverted 'ql/src/test/results/clientpositive/join9.q.out' Reverted 'ql/src/test/results/clientpositive/smb_mapjoin_11.q.out' Reverted 'ql/src/test/results/clientpositive/join30.q.out' Reverted 'ql/src/test/results/clientpositive/bucketsortoptimize_insert_6.q.out' Reverted 'ql/src/test/results/clientpositive/correlationoptimizer10.q.out' Reverted 'ql/src/test/results/clientpositive/join_nullsafe.q.out' Reverted 'ql/src/test/results/clientpositive/correlationoptimizer5.q.out' Reverted 'ql/src/test/results/clientpositive/auto_join1.q.out' Reverted 'ql/src/test/results/clientpositive/union_remove_14.q.out' Reverted 'ql/src/test/results/clientpositive/groupby_sort_skew_1_23.q.out' Reverted 'ql/src/test/results/clientpositive/auto_sortmerge_join_1.q.out' Reverted 'ql/src/test/results/clientpositive/skewjoinopt5.q.out' Reverted 'ql/src/test/results/clientpositive/union_remove_23.q.out' Reverted 'ql/src/test/results/clientpositive/ppd_join4.q.out' Reverted 'ql/src/test/results/clientpositive/mapjoin_subquery.q.out' Reverted 'ql/src/test/results/clientpositive/limit_pushdown.q.out' Reverted 'ql/src/test/results/clientpositive/bucket_map_join_1.q.out' Reverted 'ql/src/test/results/clientpositive/skewjoinopt17.q.out' Reverted 'ql/src/test/results/clientpositive/tez/auto_join1.q.out' Reverted 'ql/src/test/results/clientpositive/tez/cross_product_check_1.q.out' Reverted 'ql/src/test/results/clientpositive/tez/cross_join.q.out' Reverted 'ql/src/test/results/clientpositive/tez/cross_product_check_2.q.out' Reverted 'ql/src/test/results/clientpositive/smb_mapjoin_3.q.out' Reverted 'ql/src/test/results/clientpositive/auto_sortmerge_join_13.q.out' Reverted 'ql/src/test/results/clientpositive/index_auto_mult_tables.q.out' Reverted 'ql/src/test/results/clientpositive/skewjoin_union_remove_2.q.out' Reverted 'ql/src/test/results/clientpositive/bucketcontext_4.q.out' Reverted 'ql/src/test/results/clientpositive/skewjoinopt12.q.out' Reverted 'ql/src/test/results/clientpositive/auto_join17.q.out' Reverted 'ql/src/test/results/clientpositive/auto_join26.q.out' Reverted 'ql/src/test/results/clientpositive/sort_merge_join_desc_7.q.out' Reverted 'ql/src/test/results/clientpositive/bucketmapjoin9.q.out' Reverted 'ql/src/test/results/clientpositive/auto_join12.q.out' Reverted 'ql/src/test/results/clientpositive/bucketmapjoin13.q.out' Reverted 'ql/src/test/results/clientpositive/ppd2.q.out' Reverted 'ql/src/test/results/clientpositive/join28.q.out' Reverted 'ql/src/test/results/clientpositive/ppd_udf_case.q.out' Reverted 'ql/src/test/results/clientpositive/udf_case_column_pruning.q.out' Reverted 'ql/src/test/results/clientpositive/join14.q.out' Reverted 'ql/src/test/results/clientpositive/sort_merge_join_desc_2.q.out' Reverted 'ql/src/test/results/clientpositive/join37.q.out' Reverted 'ql/src/test/results/clientpositive/bucketmapjoin4.q.out' Reverted 'ql/src/test/results/clientpositive/auto_join30.q.out' Reverted 'ql/src/test/results/clientpositive/join_thrift.q.out' Reverted 'ql/src/test/results/clientpositive/smb_mapjoin_13.q.out' Reverted 'ql/src/test/results/clientpositive/bucketsortoptimize_insert_8.q.out' Reverted 'ql/src/test/results/clientpositive/correlationoptimizer12.q.out' Reverted 'ql/src/test/results/clientpositive/multiMapJoin2.q.out' Reverted 'ql/src/test/results/clientpositive/auto_sortmerge_join_8.q.out' Reverted 'ql/src/test/results/clientpositive/vectorized_shufflejoin.q.out' Reverted 'ql/src/test/results/clientpositive/correlationoptimizer7.q.out' Reverted 'ql/src/test/results/clientpositive/auto_join3.q.out' Reverted 'ql/src/test/results/clientpositive/index_bitmap3.q.out' Reverted 'ql/src/test/results/clientpositive/explain_rearrange.q.out' Reverted 'ql/src/test/results/clientpositive/auto_sortmerge_join_3.q.out' Reverted 'ql/src/test/results/clientpositive/bucketmapjoin_negative3.q.out' Reverted 'ql/src/test/results/clientpositive/skewjoinopt7.q.out' Reverted 'ql/src/test/results/clientpositive/correlationoptimizer2.q.out' Reverted 'ql/src/test/results/clientpositive/sample8.q.out' Reverted 'ql/src/test/results/clientpositive/groupby_position.q.out' Reverted 'ql/src/test/results/clientpositive/skewjoin_noskew.q.out' Reverted 'ql/src/test/results/clientpositive/join1.q.out' Reverted 'ql/src/test/results/clientpositive/lateral_view_noalias.q.out' Reverted 'ql/src/test/results/clientpositive/explain_logical.q.out' Reverted 'ql/src/test/results/clientpositive/reduce_deduplicate_extended.q.out' Reverted 'ql/src/test/results/clientpositive/innerjoin.q.out' Reverted 'ql/src/test/results/clientpositive/skewjoinopt19.q.out' Reverted 'ql/src/test/results/clientpositive/skewjoinopt2.q.out' Reverted 'ql/src/test/results/clientpositive/ppd_vc.q.out' Reverted 'ql/src/test/results/clientpositive/smb_mapjoin_5.q.out' Reverted 'ql/src/test/results/clientpositive/bucketcontext_6.q.out' Reverted 'ql/src/test/results/clientpositive/auto_join19.q.out' Reverted 'ql/src/test/results/clientpositive/nonmr_fetch.q.out' Reverted 'ql/src/test/results/clientpositive/cross_product_check_1.q.out' Reverted 'ql/src/test/results/clientpositive/auto_sortmerge_join_10.q.out' Reverted 'ql/src/test/results/clientpositive/bucketcontext_1.q.out' Reverted 'ql/src/test/results/clientpositive/vectorized_mapjoin.q.out' Reverted 'ql/src/test/results/clientpositive/auto_join14.q.out' Reverted 'ql/src/test/results/clientpositive/join16.q.out' Reverted 'ql/src/test/results/clientpositive/sort_merge_join_desc_4.q.out' Reverted 'ql/src/test/results/clientpositive/vectorized_bucketmapjoin1.q.out' Reverted 'ql/src/test/results/clientpositive/limit_pushdown_negative.q.out' Reverted 'ql/src/test/results/clientpositive/auto_join32.q.out' Reverted 'ql/src/test/results/clientpositive/bucketmapjoin10.q.out' Reverted 'ql/src/test/results/clientpositive/union24.q.out' Reverted 'ql/src/test/results/clientpositive/ppd_join.q.out' Reverted 'ql/src/test/results/clientpositive/join_reorder4.q.out' Reverted 'ql/src/test/results/clientpositive/join25.q.out' Reverted 'ql/src/test/results/clientpositive/table_access_keys_stats.q.out' Reverted 'ql/src/test/results/clientpositive/join11.q.out' Reverted 'ql/src/test/results/clientpositive/smb_mapjoin_15.q.out' Reverted 'ql/src/test/results/clientpositive/join34.q.out' Reverted 'ql/src/test/results/clientpositive/bucketmapjoin1.q.out' Reverted 'ql/src/test/results/clientpositive/correlationoptimizer14.q.out' Reverted 'ql/src/test/results/clientpositive/correlationoptimizer9.q.out' Reverted 'ql/src/test/results/clientpositive/smb_mapjoin_10.q.out' Reverted 'ql/src/test/results/clientpositive/bucketsortoptimize_insert_5.q.out' Reverted 'ql/src/test/results/clientpositive/auto_sortmerge_join_5.q.out' Reverted 'ql/src/test/results/clientpositive/skewjoinopt9.q.out' Reverted 'ql/src/test/results/clientpositive/correlationoptimizer4.q.out' Reverted 'ql/src/test/results/clientpositive/join_reorder.q.out' Reverted 'ql/src/test/results/clientpositive/join3.q.out' Reverted 'ql/src/test/results/clientpositive/annotate_stats_join.q.out' Reverted 'ql/src/test/results/clientpositive/quotedid_skew.q.out' Reverted 'ql/src/test/results/clientpositive/union_remove_13.q.out' Reverted 'ql/src/test/results/clientpositive/skewjoinopt4.q.out' Reverted 'ql/src/test/results/clientpositive/ppd_join3.q.out' Reverted 'ql/src/test/results/clientpositive/skewjoin.q.out' Reverted 'ql/src/test/results/clientpositive/mapjoin_distinct.q.out' Reverted 'ql/src/test/results/clientpositive/bucketcontext_8.q.out' Reverted 'ql/src/test/results/clientpositive/skewjoinopt16.q.out' Reverted 'ql/src/test/results/clientpositive/smb_mapjoin_2.q.out' Reverted 'ql/src/test/results/clientpositive/skewjoin_union_remove_1.q.out' Reverted 'ql/src/test/results/clientpositive/bucketcontext_3.q.out' Reverted 'ql/src/test/results/clientpositive/skewjoinopt11.q.out' Reverted 'ql/src/test/results/clientpositive/index_auto_self_join.q.out' Reverted 'ql/src/test/results/clientpositive/vector_decimal_mapjoin.q.out' Reverted 'ql/src/test/results/clientpositive/auto_join16.q.out' Reverted 'ql/src/test/results/clientpositive/semijoin.q.out' Reverted 'ql/src/test/results/clientpositive/skewjoinopt20.q.out' Reverted 'ql/src/test/results/clientpositive/sort_merge_join_desc_6.q.out' Reverted 'ql/src/test/results/clientpositive/bucketmapjoin8.q.out' Reverted 'ql/src/test/results/clientpositive/auto_join11.q.out' Reverted 'ql/src/test/results/clientpositive/bucketmapjoin12.q.out' Reverted 'ql/src/test/results/clientpositive/union26.q.out' Reverted 'ql/src/test/results/clientpositive/join27.q.out' Reverted 'ql/src/test/results/clientpositive/cross_join.q.out' Reverted 'ql/src/test/results/clientpositive/groupby_sort_1_23.q.out' Reverted 'ql/src/test/results/clientpositive/ppd_random.q.out' Reverted 'ql/src/test/results/clientpositive/sort_merge_join_desc_1.q.out' Reverted 'ql/src/test/results/clientpositive/smb_mapjoin_17.q.out' Reverted 'ql/src/test/results/clientpositive/ppd_repeated_alias.q.out' Reverted 'ql/src/test/results/clientpositive/join36.q.out' Reverted 'ql/src/test/results/clientpositive/bucketmapjoin3.q.out' Reverted 'ql/src/test/results/clientpositive/join22.q.out' Reverted 'ql/src/test/results/clientpositive/smb_mapjoin_12.q.out' Reverted 'ql/src/test/results/clientpositive/metadataonly1.q.out' Reverted 'ql/src/test/results/clientpositive/join31.q.out' Reverted 'ql/src/test/results/clientpositive/bucketsortoptimize_insert_7.q.out' Reverted 'ql/src/test/results/clientpositive/correlationoptimizer11.q.out' Reverted 'ql/src/test/results/clientpositive/multiMapJoin1.q.out' Reverted 'ql/src/test/results/clientpositive/join40.q.out' Reverted 'ql/src/test/results/clientpositive/auto_sortmerge_join_7.q.out' Reverted 'ql/src/test/results/clientpositive/correlationoptimizer6.q.out' Reverted 'ql/src/test/results/clientpositive/select_transform_hint.q.out' Reverted 'ql/src/test/results/clientpositive/union_top_level.q.out' Reverted 'ql/src/test/results/clientpositive/bucketsortoptimize_insert_2.q.out' Reverted 'ql/src/test/results/clientpositive/index_bitmap_auto.q.out' Reverted 'ql/src/test/results/clientpositive/bucketmapjoin_negative2.q.out' Reverted 'ql/src/test/results/clientpositive/auto_sortmerge_join_2.q.out' Reverted 'ql/src/test/results/clientpositive/skewjoinopt6.q.out' Reverted 'ql/src/test/results/clientpositive/correlationoptimizer1.q.out' Reverted 'ql/src/test/results/clientpositive/bucket_map_join_2.q.out' Reverted 'ql/src/test/results/clientpositive/skewjoinopt18.q.out' Reverted 'ql/src/test/results/clientpositive/skewjoinopt1.q.out' Reverted 'ql/src/test/results/clientpositive/smb_mapjoin_4.q.out' Reverted 'ql/src/test/results/clientpositive/ppd_union_view.q.out' Reverted 'ql/src/test/results/clientpositive/ppd_gby_join.q.out' Reverted 'ql/src/test/results/clientpositive/bucketcontext_5.q.out' Reverted 'ql/src/test/results/clientpositive/stats11.q.out' Reverted 'ql/src/test/results/compiler/plan/join3.q.xml' Reverted 'ql/src/test/results/compiler/plan/join1.q.xml' Reverted 'ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java' ++ awk '{print $2}' ++ egrep -v '^X|^Performing status on external' ++ svn status --no-ignore + rm -rf target datanucleus.log ant/target shims/target shims/0.20/target shims/0.20S/target shims/0.23/target shims/aggregator/target shims/common/target shims/common-secure/target packaging/target hbase-handler/target testutils/target jdbc/target metastore/target itests/target itests/hcatalog-unit/target itests/test-serde/target itests/qtest/target itests/hive-minikdc/target itests/hive-unit/target itests/custom-serde/target itests/util/target hcatalog/target hcatalog/core/target hcatalog/streaming/target hcatalog/server-extensions/target hcatalog/hcatalog-pig-adapter/target hcatalog/webhcat/svr/target hcatalog/webhcat/java-client/target hwi/target common/target common/src/gen service/target contrib/target serde/target beeline/target odbc/target cli/target ql/dependency-reduced-pom.xml ql/target + svn update U ql/src/java/org/apache/hadoop/hive/ql/exec/tez/DagUtils.java U ql/src/java/org/apache/hadoop/hive/ql/parse/GenTezProcContext.java U ql/src/test/results/clientpositive/tez/tez_dml.q.out Fetching external item into 'hcatalog/src/test/e2e/harness' Updated external to revision 1602653. Updated to revision 1602653. + patchCommandPath=/data/hive-ptest/working/scratch/smart-apply-patch.sh + patchFilePath=/data/hive-ptest/working/scratch/build.patch + [[ -f /data/hive-ptest/working/scratch/build.patch ]] + chmod +x /data/hive-ptest/working/scratch/smart-apply-patch.sh + /data/hive-ptest/working/scratch/smart-apply-patch.sh /data/hive-ptest/working/scratch/build.patch The patch does not appear to apply with p0, p1, or p2 + exit 1 ' {noformat} This message is automatically generated. ATTACHMENT ID: 12650163 > Fix TestHiveConf#testConfProperties test case > --------------------------------------------- > > Key: HIVE-7201 > URL: https://issues.apache.org/jira/browse/HIVE-7201 > Project: Hive > Issue Type: Bug > Components: Tests > Affects Versions: 0.13.0 > Reporter: Pankit Thapar > Assignee: Pankit Thapar > Priority: Minor > Attachments: HIVE-7201-1.patch, HIVE-7201-2.patch, > HIVE-7201.03.patch, HIVE-7201.patch > > > CHANGE 1: > TEST CASE : > The intention of TestHiveConf#testConfProperties() is to test the HiveConf > properties being set in the priority as expected. > Each HiveConf object is initialized as follows: > 1) Hadoop configuration properties are applied. > 2) ConfVar properties with non-null values are overlayed. > 3) hive-site.xml properties are overlayed. > ISSUE : > The mapreduce related configurations are loaded by JobConf and not > Configuration. > The current test tries to get the configuration properties like : > HADOOPNUMREDUCERS ("mapred.job.reduces") > from Configuration class. But these mapreduce related properties are loaded > by JobConf class from mapred-default.xml. > DETAILS : > LINE 63 : checkHadoopConf(ConfVars.HADOOPNUMREDUCERS.varname, "1"); -->fails > Because, > private void checkHadoopConf(String name, String expectedHadoopVal) { > Assert.assertEquals(expectedHadoopVal, new Configuration().get(name)); > ----> Second parameter is null, since its the JobConf class and not the > Configuration class that initializes mapred-default values. > } > Code that loads mapreduce resources is in ConfigUtil and JobConf makes a call > like this (in static block): > public class JobConf extends Configuration { > > private static final Log LOG = LogFactory.getLog(JobConf.class); > static{ > ConfigUtil.loadResources(); --> loads mapreduce related resources > (mapreduce-default.xml) > } > ..... > } > Please note, the test case assertion works fine if HiveConf() constructor is > called before this assertion since, HiveConf() triggers JobConf() > which basically sets the default values of the properties pertaining to > mapreduce. > This is why, there won't be any failures if testHiveSitePath() was run before > testConfProperties() as that would load mapreduce > properties into config properties. > FIX: > Instead of using a Configuration object, we can use the JobConf object to get > the default values used by hadoop/mapreduce. > CHANGE 2: > In TestHiveConf#testHiveSitePath(), a call to static method > getHiveSiteLocation() should be called statically instead of using an object. -- This message was sent by Atlassian JIRA (v6.2#6252)