[ https://issues.apache.org/jira/browse/HIVE-7201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14026370#comment-14026370 ]
Hive QA commented on HIVE-7201: ------------------------------- {color:red}Overall{color}: -1 no tests executed Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12649474/HIVE-7201.patch Test results: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-Build/423/testReport Console output: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-Build/423/console Test logs: http://ec2-174-129-184-35.compute-1.amazonaws.com/logs/PreCommit-HIVE-Build-423/ Messages: {noformat} Executing org.apache.hive.ptest.execution.PrepPhase Tests exited with: NonZeroExitCodeException Command 'bash /data/hive-ptest/working/scratch/source-prep.sh' failed with exit status 1 and output '+ [[ -n /usr/java/jdk1.7.0_45-cloudera ]] + export JAVA_HOME=/usr/java/jdk1.7.0_45-cloudera + JAVA_HOME=/usr/java/jdk1.7.0_45-cloudera + export PATH=/usr/java/jdk1.7.0_45-cloudera/bin/:/usr/java/jdk1.6.0_34/bin:/usr/local/apache-maven-3.0.5/bin:/usr/local/apache-maven-3.0.5/bin:/usr/java/jdk1.6.0_34/bin:/usr/local/apache-ant-1.9.1/bin:/usr/local/bin:/bin:/usr/bin:/usr/local/sbin:/usr/sbin:/sbin:/home/hiveptest/bin + PATH=/usr/java/jdk1.7.0_45-cloudera/bin/:/usr/java/jdk1.6.0_34/bin:/usr/local/apache-maven-3.0.5/bin:/usr/local/apache-maven-3.0.5/bin:/usr/java/jdk1.6.0_34/bin:/usr/local/apache-ant-1.9.1/bin:/usr/local/bin:/bin:/usr/bin:/usr/local/sbin:/usr/sbin:/sbin:/home/hiveptest/bin + export 'ANT_OPTS=-Xmx1g -XX:MaxPermSize=256m ' + ANT_OPTS='-Xmx1g -XX:MaxPermSize=256m ' + export 'M2_OPTS=-Xmx1g -XX:MaxPermSize=256m -Dhttp.proxyHost=localhost -Dhttp.proxyPort=3128' + M2_OPTS='-Xmx1g -XX:MaxPermSize=256m -Dhttp.proxyHost=localhost -Dhttp.proxyPort=3128' + cd /data/hive-ptest/working/ + tee /data/hive-ptest/logs/PreCommit-HIVE-Build-423/source-prep.txt + [[ false == \t\r\u\e ]] + mkdir -p maven ivy + [[ svn = \s\v\n ]] + [[ -n '' ]] + [[ -d apache-svn-trunk-source ]] + [[ ! -d apache-svn-trunk-source/.svn ]] + [[ ! -d apache-svn-trunk-source ]] + cd apache-svn-trunk-source + svn revert -R . Reverted 'hcatalog/core/src/main/java/org/apache/hive/hcatalog/mapreduce/SpecialCases.java' Reverted 'hcatalog/hcatalog-pig-adapter/src/main/java/org/apache/hive/hcatalog/pig/HCatLoader.java' ++ egrep -v '^X|^Performing status on external' ++ awk '{print $2}' ++ svn status --no-ignore + rm -rf target datanucleus.log ant/target shims/target shims/0.20/target shims/0.20S/target shims/0.23/target shims/aggregator/target shims/common/target shims/common-secure/target packaging/target hbase-handler/target testutils/target jdbc/target metastore/target itests/target itests/hcatalog-unit/target itests/test-serde/target itests/qtest/target itests/hive-minikdc/target itests/hive-unit/target itests/custom-serde/target itests/util/target hcatalog/target hcatalog/core/target hcatalog/streaming/target hcatalog/server-extensions/target hcatalog/hcatalog-pig-adapter/target hcatalog/webhcat/svr/target hcatalog/webhcat/java-client/target hwi/target common/target common/src/gen contrib/target service/target serde/target beeline/target odbc/target cli/target ql/dependency-reduced-pom.xml ql/target + svn update Fetching external item into 'hcatalog/src/test/e2e/harness' External at revision 1601612. At revision 1601612. + patchCommandPath=/data/hive-ptest/working/scratch/smart-apply-patch.sh + patchFilePath=/data/hive-ptest/working/scratch/build.patch + [[ -f /data/hive-ptest/working/scratch/build.patch ]] + chmod +x /data/hive-ptest/working/scratch/smart-apply-patch.sh + /data/hive-ptest/working/scratch/smart-apply-patch.sh /data/hive-ptest/working/scratch/build.patch The patch does not appear to apply with p0, p1, or p2 + exit 1 ' {noformat} This message is automatically generated. ATTACHMENT ID: 12649474 > Fix TestHiveConf#testConfProperties test case > --------------------------------------------- > > Key: HIVE-7201 > URL: https://issues.apache.org/jira/browse/HIVE-7201 > Project: Hive > Issue Type: Bug > Components: Tests > Affects Versions: 0.13.0 > Reporter: Pankit Thapar > Priority: Minor > Attachments: HIVE-7201.patch > > > CHANGE 1: > TEST CASE : > The intention of TestHiveConf#testConfProperties() is to test the HiveConf > properties being set in the priority as expected. > Each HiveConf object is initialized as follows: > 1) Hadoop configuration properties are applied. > 2) ConfVar properties with non-null values are overlayed. > 3) hive-site.xml properties are overlayed. > ISSUE : > The mapreduce related configurations are loaded by JobConf and not > Configuration. > The current test tries to get the configuration properties like : > HADOOPNUMREDUCERS ("mapred.job.reduces") > from Configuration class. But these mapreduce related properties are loaded > by JobConf class from mapred-default.xml. > DETAILS : > LINE 63 : checkHadoopConf(ConfVars.HADOOPNUMREDUCERS.varname, "1"); -->fails > Because, > private void checkHadoopConf(String name, String expectedHadoopVal) { > Assert.assertEquals(expectedHadoopVal, new Configuration().get(name)); > ----> Second parameter is null, since its the JobConf class and not the > Configuration class that initializes mapred-default values. > } > Code that loads mapreduce resources is in ConfigUtil and JobConf makes a call > like this (in static block): > public class JobConf extends Configuration { > > private static final Log LOG = LogFactory.getLog(JobConf.class); > static{ > ConfigUtil.loadResources(); --> loads mapreduce related resources > (mapreduce-default.xml) > } > ..... > } > Please note, the test case assertion works fine if HiveConf() constructor is > called before this assertion since, HiveConf() triggers JobConf() > which basically sets the default values of the properties pertaining to > mapreduce. > This is why, there won't be any failures if testHiveSitePath() was run before > testConfProperties() as that would load mapreduce > properties into config properties. > FIX: > Instead of using a Configuration object, we can use the JobConf object to get > the default values used by hadoop/mapreduce. > CHANGE 2: > In TestHiveConf#testHiveSitePath(), a call to static method > getHiveSiteLocation() should be called statically instead of using an object. -- This message was sent by Atlassian JIRA (v6.2#6252)