> On June 3, 2014, 2:37 p.m., Swarnim Kulkarni wrote: > > common/src/java/org/apache/hadoop/hive/common/FileUtils.java, line 591 > > <https://reviews.apache.org/r/21846/diff/2/?file=589240#file589240line591> > > > > Like I said its pretty minor but in my opinion its easy to miss the > > intention of a method when someone has to look through half a dozen > > arguments to understand that. A simple method name like "renameWithPerms" > > make things more clear for a first time consumer.
OK, changed to "renameWithPerms". - Ashish ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21846/#review44626 ----------------------------------------------------------- On June 3, 2014, 9:10 p.m., Ashish Singh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21846/ > ----------------------------------------------------------- > > (Updated June 3, 2014, 9:10 p.m.) > > > Review request for hive and Szehon Ho. > > > Bugs: HIVE-7117 > https://issues.apache.org/jira/browse/HIVE-7117 > > > Repository: hive-git > > > Description > ------- > > Correct FolderPermissionsBase test and change rename method to inherit > permissions and/or extended ACLs > > > Inherit permissions from parent while renaming directories or files under hive > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/common/FileUtils.java 4591678 > > itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/security/FolderPermissionBase.java > 57fe4cf > metastore/src/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java > 221b010 > metastore/src/java/org/apache/hadoop/hive/metastore/Warehouse.java c1790b4 > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFInFile.java > ea52537 > > Diff: https://reviews.apache.org/r/21846/diff/ > > > Testing > ------- > > Tested with itests. > > > Thanks, > > Ashish Singh > >
