----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21846/#review44602 -----------------------------------------------------------
Thanks for rebasing! One minor suggestion (apologies for not seeing it earlier). Other than that, looks good metastore/src/java/org/apache/hadoop/hive/metastore/Warehouse.java <https://reviews.apache.org/r/21846/#comment79023> I missed this earlier, can we just return the value returned from here instead of having an extra returns after this line? - Szehon Ho On June 3, 2014, 3:38 a.m., Ashish Singh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21846/ > ----------------------------------------------------------- > > (Updated June 3, 2014, 3:38 a.m.) > > > Review request for hive and Szehon Ho. > > > Bugs: HIVE-7117 > https://issues.apache.org/jira/browse/HIVE-7117 > > > Repository: hive-git > > > Description > ------- > > Correct FolderPermissionsBase test and change rename method to inherit > permissions and/or extended ACLs > > > Inherit permissions from parent while renaming directories or files under hive > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/common/FileUtils.java 4591678 > > itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/security/FolderPermissionBase.java > 57fe4cf > metastore/src/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java > 221b010 > metastore/src/java/org/apache/hadoop/hive/metastore/Warehouse.java c1790b4 > > Diff: https://reviews.apache.org/r/21846/diff/ > > > Testing > ------- > > Tested with itests. > > > Thanks, > > Ashish Singh > >
