-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18293/
-----------------------------------------------------------

(Updated Feb. 27, 2014, 6:56 p.m.)


Review request for hive, Ashutosh Chauhan and Gunther Hagleitner.


Changes
-------

updated.
Gunther thanks for your feedback.


Bugs: HIVE-6393
    https://issues.apache.org/jira/browse/HIVE-6393


Repository: hive-git


Description
-------

Support queries of the form:

create table r1(a int);
create table r2(b);
select a, b
from r1 join r2 on a = b

This becomes more useful in old style syntax:

select a, b
from r1, r2
where a = b


Diffs (updated)
-----

  ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java a01aa0e 
  ql/src/test/org/apache/hadoop/hive/ql/parse/TestQBJoinTreeApplyPredicate.java 
9e77949 
  ql/src/test/queries/clientnegative/join_cond_unqual_ambiguous.q PRE-CREATION 
  ql/src/test/queries/clientnegative/join_cond_unqual_ambiguous_vc.q 
PRE-CREATION 
  ql/src/test/queries/clientpositive/join_cond_pushdown_unqual1.q PRE-CREATION 
  ql/src/test/queries/clientpositive/join_cond_pushdown_unqual2.q PRE-CREATION 
  ql/src/test/queries/clientpositive/join_cond_pushdown_unqual3.q PRE-CREATION 
  ql/src/test/queries/clientpositive/join_cond_pushdown_unqual4.q PRE-CREATION 
  ql/src/test/queries/clientpositive/subquery_unqualcolumnrefs.q PRE-CREATION 
  ql/src/test/results/clientnegative/join_cond_unqual_ambiguous.q.out 
PRE-CREATION 
  ql/src/test/results/clientnegative/join_cond_unqual_ambiguous_vc.q.out 
PRE-CREATION 
  ql/src/test/results/clientpositive/join_cond_pushdown_unqual1.q.out 
PRE-CREATION 
  ql/src/test/results/clientpositive/join_cond_pushdown_unqual2.q.out 
PRE-CREATION 
  ql/src/test/results/clientpositive/join_cond_pushdown_unqual3.q.out 
PRE-CREATION 
  ql/src/test/results/clientpositive/join_cond_pushdown_unqual4.q.out 
PRE-CREATION 
  ql/src/test/results/clientpositive/subquery_unqualcolumnrefs.q.out 
PRE-CREATION 

Diff: https://reviews.apache.org/r/18293/diff/


Testing
-------

added new tests
ran all existing join tests


Thanks,

Harish Butani

Reply via email to