----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18293/#review35501 -----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java <https://reviews.apache.org/r/18293/#comment66054> rawtypes because of Operator? Can't you use Operator<?> or Operator<? extends OperatorDesc>? ql/src/test/queries/clientpositive/join_cond_pushdown_unqual1.q <https://reviews.apache.org/r/18293/#comment66091> I'm not sure that's covered elsewhere, but does it make sense to add some negative tests? (i.e.: doesn't exist, ambiguous etc) - Gunther Hagleitner On Feb. 23, 2014, 3:28 a.m., Harish Butani wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18293/ > ----------------------------------------------------------- > > (Updated Feb. 23, 2014, 3:28 a.m.) > > > Review request for hive, Ashutosh Chauhan and Gunther Hagleitner. > > > Bugs: HIVE-6393 > https://issues.apache.org/jira/browse/HIVE-6393 > > > Repository: hive-git > > > Description > ------- > > Support queries of the form: > > create table r1(a int); > create table r2(b); > select a, b > from r1 join r2 on a = b > > This becomes more useful in old style syntax: > > select a, b > from r1, r2 > where a = b > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java a01aa0e > > ql/src/test/org/apache/hadoop/hive/ql/parse/TestQBJoinTreeApplyPredicate.java > 9e77949 > ql/src/test/queries/clientpositive/join_cond_pushdown_unqual1.q > PRE-CREATION > ql/src/test/queries/clientpositive/join_cond_pushdown_unqual2.q > PRE-CREATION > ql/src/test/queries/clientpositive/join_cond_pushdown_unqual3.q > PRE-CREATION > ql/src/test/queries/clientpositive/join_cond_pushdown_unqual4.q > PRE-CREATION > ql/src/test/queries/clientpositive/subquery_unqualcolumnrefs.q PRE-CREATION > ql/src/test/results/clientpositive/join_cond_pushdown_unqual1.q.out > PRE-CREATION > ql/src/test/results/clientpositive/join_cond_pushdown_unqual2.q.out > PRE-CREATION > ql/src/test/results/clientpositive/join_cond_pushdown_unqual3.q.out > PRE-CREATION > ql/src/test/results/clientpositive/join_cond_pushdown_unqual4.q.out > PRE-CREATION > ql/src/test/results/clientpositive/subquery_unqualcolumnrefs.q.out > PRE-CREATION > > Diff: https://reviews.apache.org/r/18293/diff/ > > > Testing > ------- > > added new tests > ran all existing join tests > > > Thanks, > > Harish Butani > >
