> On Feb. 11, 2014, 2:35 a.m., Mohammad Islam wrote: > > metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java, > > line 866 > > <https://reviews.apache.org/r/17930/diff/1/?file=482265#file482265line866> > > > > adding " & dataSuccess" is required here? > >
Thanks, fixed all instances of redundant and-ing. > On Feb. 11, 2014, 2:35 a.m., Mohammad Islam wrote: > > metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java, > > line 3231 > > <https://reviews.apache.org/r/17930/diff/1/?file=482265#file482265line3231> > > > > Is it possible none of the data deletion succeeds? If that is possible, > > the message doesn't seem correct. > > Yes, most instances either all are deleted successfull or none. Changed the message to better reflect that. - Szehon ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17930/#review34163 ----------------------------------------------------------- On Feb. 11, 2014, 1:33 a.m., Szehon Ho wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17930/ > ----------------------------------------------------------- > > (Updated Feb. 11, 2014, 1:33 a.m.) > > > Review request for hive. > > > Bugs: HIVE-6402 > https://issues.apache.org/jira/browse/HIVE-6402 > > > Repository: hive-git > > > Description > ------- > > It is probably not desirable to forcibly delete the data if the trash is > misconfigured. So this change at least informs the user by throwing an > exception, indicating that the data deletion failed. > > > Diffs > ----- > > metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java > 4905be0 > > Diff: https://reviews.apache.org/r/17930/diff/ > > > Testing > ------- > > > Thanks, > > Szehon Ho > >
