----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17930/#review34206 -----------------------------------------------------------
metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java <https://reviews.apache.org/r/17930/#comment64222> It seems interesting to know what's the impact of throwing an exception here on the caller, because previously the exception is not thrown. The caller seems further throwin g the exception. metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java <https://reviews.apache.org/r/17930/#comment64220> It seems interesting to know what's the impact of throwing an exception here on the caller, because previously the exception is not thrown. The caller seems further throwin g the exception. metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java <https://reviews.apache.org/r/17930/#comment64221> It seems interesting to know what's the impact of throwing an exception here on the caller, because previously the exception is not thrown. The caller seems further throwin g the exception. - Xuefu Zhang On Feb. 11, 2014, 1:33 a.m., Szehon Ho wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17930/ > ----------------------------------------------------------- > > (Updated Feb. 11, 2014, 1:33 a.m.) > > > Review request for hive. > > > Bugs: HIVE-6402 > https://issues.apache.org/jira/browse/HIVE-6402 > > > Repository: hive-git > > > Description > ------- > > It is probably not desirable to forcibly delete the data if the trash is > misconfigured. So this change at least informs the user by throwing an > exception, indicating that the data deletion failed. > > > Diffs > ----- > > metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java > 4905be0 > > Diff: https://reviews.apache.org/r/17930/diff/ > > > Testing > ------- > > > Thanks, > > Szehon Ho > >
