Thanks Alan.  Also thanks for the formatting fixes -- big improvement.

Could you please squish one remaining ant in the new
#10<https://cwiki.apache.org/confluence/display/Hive/HowToContribute#HowToContribute-GeneratingThriftCode>
?

8.   Now use svn status and svn diff to verify that the regenerated code
> corresponds only to the changes you made tohive_metastore.thrift. You may
> also need svn add if new files were generated (and svn remove if files
> have been obsoleted).

9.   cd /path/to/hive-trunk

10.  ant clean package

11.  Verify that Hive is still working correctly with both embedded and
> remote metastore configurations.





-- Lefty


On Fri, Jan 3, 2014 at 5:09 PM, Alan Gates <ga...@hortonworks.com> wrote:

> Ok, I’ve updated it to just have the maven instructions, since I’m
> assuming no one cares about the ant ones anymore.
>
> Alan.
>
> On Jan 3, 2014, at 3:46 PM, Alan Gates <ga...@hortonworks.com> wrote:
>
> >
> >>
> >>
> >>>
> >>> The rest of the "ant" instances are okay because the MVN section
> afterwards
> >>> gives the alternative, but should we keep ant or make the replacements?
> >>>
> >>>  - 9.  Now you can run the ant 'thriftif' target ...
> >>>  - 11.  ant thriftif -Dthrift.home=...
> >>>  - 15.  ant thriftif
> >>>  - 18. ant clean package
> >>>  - The maven equivalent of ant thriftif is:
> >>>
> >>> mvn clean install -Pthriftif -DskipTests -Dthrift.home=/usr/local
> >>>
> >>>
> >>>
> >> I have not generated the thrift stuff recently. It would be great if
> Alan
> >> or someone else who has would update this section.
> >
> > I can take a look at this.  It works with pretty minimal changes.
> >
> > Alan.
> >
>
>
> --
> CONFIDENTIALITY NOTICE
> NOTICE: This message is intended for the use of the individual or entity to
> which it is addressed and may contain information that is confidential,
> privileged and exempt from disclosure under applicable law. If the reader
> of this message is not the intended recipient, you are hereby notified that
> any printing, copying, dissemination, distribution, disclosure or
> forwarding of this communication is strictly prohibited. If you have
> received this communication in error, please contact the sender immediately
> and delete it from your system. Thank You.
>

Reply via email to