Ping. (Need help cleaning up some ants.) These sections in How To Contribute<https://cwiki.apache.org/confluence/display/Hive/HowToContribute> need review/revision:
- Coding Convention<https://cwiki.apache.org/confluence/display/Hive/HowToContribute#HowToContribute-CodingConvention> - Check for new Checkstyle <http://checkstyle.sourceforge.net/> violations by running ant checkstyle, ... *[mvn checkstyle?]* - Define methods within your class whose names begin with test, and call JUnit's many assert methods to verify conditions; these methods will be executed when you run ant test. *[mvn test?]* - Add a Unit Test<https://cwiki.apache.org/confluence/display/Hive/HowToContribute#HowToContribute-AddaUnitTest> - We can run "ant test -Dtestcase=TestAbc" where TestAbc is the name of the new class. This will test only the new testcase, which will be faster than "ant test" which tests all testcases. *[change ant to mvn twice; also change -Dtestcase to -Dtest?]* - Contributing your work<https://cwiki.apache.org/confluence/display/Hive/HowToContribute#HowToContribute-Contributingyourwork> - Folks should run ant clean package test before selecting *Submit Patch*. *[mvn clean package test?]* Also, should we keep ant or make replacements in Generating Thrift Code<https://cwiki.apache.org/confluence/display/Hive/HowToContribute#HowToContribute-GeneratingThriftCode>? (Steps 9, 11, 15, 18.) Are the old instructions still useful for contributors? Thanks. -- Lefty On Mon, Nov 18, 2013 at 12:21 PM, Lefty Leverenz <leftylever...@gmail.com>wrote: > Thanks for the typo alert Remus, I've changed -Dcase=TestCliDriver to > -Dtest=TestCliDriver. > > But > HowToContribute<https://cwiki.apache.org/confluence/display/Hive/HowToContribute#HowToContribute>still > has several instances of "ant" that should be changed to "mvn" -- > some are simple replacements but others might need additional changes: > > - Check for new Checkstyle <http://checkstyle.sourceforge.net/> violations > by running ant checkstyle, ... [mvn checkstyle?] > - Define methods within your class whose names begin with test, and > call JUnit's many assert methods to verify conditions; these methods will > be executed when you run ant test. [simple replacement] > - (2 ants) We can run "ant test -Dtestcase=TestAbc" where TestAbc is > the name of the new class. This will test only the new testcase, which will > be faster than "ant test" which tests all testcases. [change ant to mvn > twice; also change -Dtestcase to -Dtest?] > - Folks should run ant clean package test before selecting *Submit > Patch*. [mvn clean package?] > > The rest of the "ant" instances are okay because the MVN section > afterwards gives the alternative, but should we keep ant or make the > replacements? > > - 9. Now you can run the ant 'thriftif' target ... > - 11. ant thriftif -Dthrift.home=... > - 15. ant thriftif > - 18. ant clean package > - The maven equivalent of ant thriftif is: > > mvn clean install -Pthriftif -DskipTests -Dthrift.home=/usr/local > > > > -- Lefty > > > On Mon, Nov 18, 2013 at 9:35 AM, Remus Rusanu <rem...@microsoft.com>wrote: > >> Nevermind, discovered >> https://cwiki.apache.org/confluence/display/Hive/HiveDeveloperFAQ#HiveDeveloperFAQ-HowdoIruntheclientpositive%2Fclientnegativeunittests%3F >> >> cd itests/qtest >> mvn test -Dtest=TestCliDriver >> >> I still get failures, but at least now I can investigate >> >> Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 31.9 sec >> <<< FAILURE! - in org.apache.hadoop.hive.cli.TestCliDriver >> initializationError(org.apache.hadoop.hive.cli.TestCliDriver) Time >> elapsed: 0.005 sec <<< FAILURE! >> java.lang.AssertionError: null >> at >> org.apache.hadoop.hive.ql.QTestUtil.getHdfsUriString(QTestUtil.java:288) >> at >> org.apache.hadoop.hive.ql.QTestUtil.convertPathsFromWindowsToHdfs(QTestUtil.java:276) >> at >> org.apache.hadoop.hive.ql.QTestUtil.initConf(QTestUtil.java:233) >> at org.apache.hadoop.hive.ql.QTestUtil.<init>(QTestUtil.java:317) >> at >> org.apache.hadoop.hive.cli.TestCliDriver.<clinit>(TestCliDriver.java:39) >> >> >> >> >> From: Remus Rusanu [mailto:rem...@microsoft.com] >> Sent: Monday, November 18, 2013 2:30 PM >> To: dev@hive.apache.org >> Cc: Ashutosh Chauhan; Tony Murphy (HDINSIGHT); Eric Hanson (SQL SERVER) >> Subject: How do you run single query test(s) after mavenization? >> >> I'm trying to run as per the updated Contributing guide< >> https://cwiki.apache.org/confluence/display/Hive/HowToContribute#HowToContribute >> >: >> >> mvn test -Dtest=TestCliDriver "-Dqfile=vectorized_mapjoin.q" >> >> (The guide actually recommends -Dcase=TestCliDriver but using -Dcase >> executes all tests. In fact -Dtest=... is recommended just few lines above, >> I guess -Dcase=... is a typo) >> >> But the run succeeds w/o actually executing any query test (I tried >> removing -Dqfile= and does not make any difference). >> >> I attached the output of the mvn test -Dtest=TestCliDriver run, if it >> sheds any light. >> >> Thanks, >> ~Remus >> >> >> >
