----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15898/#review29932 -----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/parse/SubQueryUtils.java <https://reviews.apache.org/r/15898/#comment57405> It will be good to add a comment for all these static methods to tell what kind of query form each of these methods are generating like: select ... from T1 LOJ T2 .. and so on.. - Ashutosh Chauhan On Dec. 2, 2013, 6:58 p.m., Harish Butani wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15898/ > ----------------------------------------------------------- > > (Updated Dec. 2, 2013, 6:58 p.m.) > > > Review request for hive and Ashutosh Chauhan. > > > Bugs: hive-5830 > https://issues.apache.org/jira/browse/hive-5830 > > > Repository: hive-git > > > Description > ------- > > As pointed out by Sivaramakrishnan Narayanan in HIVE-784 for not in when > there are nulls in the SubQuery's matching column the Outer Query should > return no rows. > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/parse/QBSubQuery.java 753df79a > ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java e9d9ee7 > ql/src/java/org/apache/hadoop/hive/ql/parse/SubQueryUtils.java ddc096d > ql/src/test/queries/clientpositive/subquery_notin.q d7eca3e > ql/src/test/results/clientpositive/subquery_multiinsert.q.out a917a13 > ql/src/test/results/clientpositive/subquery_notin.q.out bf87e3b > ql/src/test/results/clientpositive/subquery_notin_having.q.out f9598c2 > > Diff: https://reviews.apache.org/r/15898/diff/ > > > Testing > ------- > > ran all subquery tests. > added new test for notin with null values. > > > Thanks, > > Harish Butani > >
