----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15898/ -----------------------------------------------------------
Review request for hive and Ashutosh Chauhan. Bugs: hive-5830 https://issues.apache.org/jira/browse/hive-5830 Repository: hive-git Description ------- As pointed out by Sivaramakrishnan Narayanan in HIVE-784 for not in when there are nulls in the SubQuery's matching column the Outer Query should return no rows. Diffs ----- ql/src/java/org/apache/hadoop/hive/ql/parse/QBSubQuery.java 753df79a ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java e9d9ee7 ql/src/java/org/apache/hadoop/hive/ql/parse/SubQueryUtils.java ddc096d ql/src/test/queries/clientpositive/subquery_notin.q d7eca3e ql/src/test/results/clientpositive/subquery_multiinsert.q.out a917a13 ql/src/test/results/clientpositive/subquery_notin.q.out bf87e3b ql/src/test/results/clientpositive/subquery_notin_having.q.out f9598c2 Diff: https://reviews.apache.org/r/15898/diff/ Testing ------- ran all subquery tests. added new test for notin with null values. Thanks, Harish Butani