----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15869/#review29493 -----------------------------------------------------------
ql/src/gen/vectorization/ExpressionTemplates/ColumnDivideColumn.txt <https://reviews.apache.org/r/15869/#comment56790> Please remove trailing white space in your new templates ql/src/gen/vectorization/ExpressionTemplates/ColumnDivideColumn.txt <https://reviews.apache.org/r/15869/#comment56791> Fix comment to use correct file name ql/src/gen/vectorization/ExpressionTemplates/ColumnDivideScalar.txt <https://reviews.apache.org/r/15869/#comment56796> correct file name in comment ql/src/gen/vectorization/ExpressionTemplates/ColumnDivideScalar.txt <https://reviews.apache.org/r/15869/#comment56795> you could simplify this to set the output to repeating and make it null, since all outputs will be null if value == 0 ql/src/gen/vectorization/ExpressionTemplates/ScalarDivideColumn.txt <https://reviews.apache.org/r/15869/#comment56797> correct file name in comment ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/LongColDivideLongColumn.java <https://reviews.apache.org/r/15869/#comment56800> I think the output will be always all nulls in this case so you can simplify it to always set output to repeating and null. ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/LongColDivideLongScalar.java <https://reviews.apache.org/r/15869/#comment56801> same thing -- output will be null and repeating so you can simplify ql/src/test/queries/clientpositive/vectorization_div0.q <https://reviews.apache.org/r/15869/#comment56811> Please add a basic sanity check of / by 0 in the junit tests. ql/src/test/queries/clientpositive/vectorization_div0.q <https://reviews.apache.org/r/15869/#comment56809> I tried this and it does not vectorize. Need to make sure all the queries vectorize. Consider using explain in the .q test as well to record that the query is vectorized. ql/src/test/queries/clientpositive/vectorization_div0.q <https://reviews.apache.org/r/15869/#comment56810> COALESCE does not vectorize yet - Eric Hanson On Nov. 27, 2013, 2:20 a.m., Sergey Shelukhin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15869/ > ----------------------------------------------------------- > > (Updated Nov. 27, 2013, 2:20 a.m.) > > > Review request for hive. > > > Repository: hive-git > > > Description > ------- > > HIVE-5895 vectorization handles division by zero differently from normal > execution > > > Diffs > ----- > > ant/src/org/apache/hadoop/hive/ant/GenVectorCode.java 5dc50d6 > ql/src/gen/vectorization/ExpressionTemplates/ColumnDivideColumn.txt > PRE-CREATION > ql/src/gen/vectorization/ExpressionTemplates/ColumnDivideScalar.txt > PRE-CREATION > ql/src/gen/vectorization/ExpressionTemplates/ScalarDivideColumn.txt > PRE-CREATION > > ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/LongColDivideLongColumn.java > 482df3c > > ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/LongColDivideLongScalar.java > 7d517ca > > ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/LongScalarDivideLongColumn.java > e1ecefa > ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/NullUtil.java > e1867a2 > ql/src/test/queries/clientpositive/vectorization_div0.q PRE-CREATION > ql/src/test/results/clientpositive/vectorization_div0.q.out PRE-CREATION > ql/src/test/results/clientpositive/vectorization_short_regress.q.out > c9296e1 > > Diff: https://reviews.apache.org/r/15869/diff/ > > > Testing > ------- > > > Thanks, > > Sergey Shelukhin > >
