> On Nov. 27, 2013, 7:02 p.m., Eric Hanson wrote: > > ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/LongColDivideLongColumn.java, > > line 101 > > <https://reviews.apache.org/r/15869/diff/1/?file=391380#file391380line101> > > > > I think the output will be always all nulls in this case so you can > > simplify it to always set output to repeating and null. > > Sergey Shelukhin wrote: > same as above
see my comment on the above > On Nov. 27, 2013, 7:02 p.m., Eric Hanson wrote: > > ql/src/gen/vectorization/ExpressionTemplates/ColumnDivideScalar.txt, line 73 > > <https://reviews.apache.org/r/15869/diff/1/?file=391378#file391378line73> > > > > you could simplify this to set the output to repeating and make it > > null, since all outputs will be null if value == 0 > > Sergey Shelukhin wrote: > that's what I do if there's no selected in use; should it be done also > w/selected? for col/value, when value (the scalar) is 0, all outputs will be null, so yes, you should make it isRepeating even if selected is in use - Eric ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15869/#review29493 ----------------------------------------------------------- On Dec. 3, 2013, 9:44 p.m., Sergey Shelukhin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15869/ > ----------------------------------------------------------- > > (Updated Dec. 3, 2013, 9:44 p.m.) > > > Review request for hive. > > > Repository: hive-git > > > Description > ------- > > HIVE-5895 vectorization handles division by zero differently from normal > execution > > > Diffs > ----- > > ant/src/org/apache/hadoop/hive/ant/GenVectorCode.java 5dc50d6 > ql/src/gen/vectorization/ExpressionTemplates/ColumnDivideColumn.txt > PRE-CREATION > ql/src/gen/vectorization/ExpressionTemplates/ColumnDivideScalar.txt > PRE-CREATION > ql/src/gen/vectorization/ExpressionTemplates/ScalarDivideColumn.txt > PRE-CREATION > > ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/LongColDivideLongColumn.java > 482df3c > > ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/LongColDivideLongScalar.java > 7d517ca > > ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/LongScalarDivideLongColumn.java > e1ecefa > ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/NullUtil.java > e1867a2 > ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/Vectorizer.java > 1b79401 > > ql/src/test/org/apache/hadoop/hive/ql/exec/vector/expressions/TestVectorArithmeticExpressions.java > 9de8461 > > ql/src/test/org/apache/hadoop/hive/ql/exec/vector/expressions/TestVectorScalarColArithmetic.java > fa4da40 > ql/src/test/queries/clientpositive/vectorization_div0.q PRE-CREATION > ql/src/test/results/clientpositive/vectorization_div0.q.out PRE-CREATION > ql/src/test/results/clientpositive/vectorization_short_regress.q.out > 18ff938 > > Diff: https://reviews.apache.org/r/15869/diff/ > > > Testing > ------- > > > Thanks, > > Sergey Shelukhin > >
