----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14428/#review26659 -----------------------------------------------------------
trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java <https://reviews.apache.org/r/14428/#comment51935> Yeah, this method is for serializing filter expressions which are always of type ExprNodeGenericFuncDesc. We should utilize that info for both code clarity as well as for slightly smaller serialization footprint. trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java <https://reviews.apache.org/r/14428/#comment51936> Yup.. you were right earlier :) trunk/ql/src/java/org/apache/hadoop/hive/ql/index/compact/CompactIndexHandler.java <https://reviews.apache.org/r/14428/#comment51937> These predicates are all filter expressions, so they must be of type ExprNodeGenericFuncDesc. You are correct that its better to update return method, but this patch is already much bigger than I wanted it to be, so I will stop my refactoring here and will do more later in another jira. trunk/ql/src/java/org/apache/hadoop/hive/ql/optimizer/ppr/PartitionPruner.java <https://reviews.apache.org/r/14428/#comment51938> At this point this function must return ExprNodeGenericFuncDesc, thats why illegalstateException It can only return ExprNodeFuncDesc from previous if block where its testing for UDFOpAnd and thats why we cant change return type. trunk/ql/src/java/org/apache/hadoop/hive/ql/ppd/OpProcFactory.java <https://reviews.apache.org/r/14428/#comment51939> Nopes, return type for overloaded version of this method changed, not for this signature. trunk/ql/src/test/org/apache/hadoop/hive/ql/io/sarg/TestSearchArgumentImpl.java <https://reviews.apache.org/r/14428/#comment51940> Decoder is needed to decode the xml. This is test only code. Further for non-default case, so wants to keep it simple. trunk/ql/src/test/org/apache/hadoop/hive/ql/io/sarg/TestSearchArgumentImpl.java <https://reviews.apache.org/r/14428/#comment51941> Could be. Perhaps these tests could be rewritten, but that will be follow-up jira. - Ashutosh Chauhan On Oct. 2, 2013, 1:07 p.m., Ashutosh Chauhan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14428/ > ----------------------------------------------------------- > > (Updated Oct. 2, 2013, 1:07 p.m.) > > > Review request for hive. > > > Bugs: HIVE-5411 > https://issues.apache.org/jira/browse/HIVE-5411 > > > Repository: hive > > > Description > ------- > > Migrate expression serialization to Kryo > > > Diffs > ----- > > > trunk/hbase-handler/src/java/org/apache/hadoop/hive/hbase/HBaseStorageHandler.java > 1528446 > > trunk/hbase-handler/src/java/org/apache/hadoop/hive/hbase/HiveHBaseTableInputFormat.java > 1528446 > > trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/ExprNodeGenericFuncEvaluator.java > 1528446 > trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java 1528446 > > trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorizationContext.java > 1528446 > > trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/vector/udf/VectorUDFAdaptor.java > 1528446 > > trunk/ql/src/java/org/apache/hadoop/hive/ql/index/IndexPredicateAnalyzer.java > 1528446 > trunk/ql/src/java/org/apache/hadoop/hive/ql/index/IndexSearchCondition.java > 1528446 > > trunk/ql/src/java/org/apache/hadoop/hive/ql/index/compact/CompactIndexHandler.java > 1528446 > trunk/ql/src/java/org/apache/hadoop/hive/ql/io/HiveInputFormat.java 1528446 > trunk/ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java > 1528446 > trunk/ql/src/java/org/apache/hadoop/hive/ql/io/sarg/SearchArgument.java > 1528446 > trunk/ql/src/java/org/apache/hadoop/hive/ql/io/sarg/SearchArgumentImpl.java > 1528446 > trunk/ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 1528446 > > trunk/ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveStoragePredicateHandler.java > 1528446 > > trunk/ql/src/java/org/apache/hadoop/hive/ql/optimizer/index/RewriteCanApplyProcFactory.java > 1528446 > > trunk/ql/src/java/org/apache/hadoop/hive/ql/optimizer/pcr/PcrExprProcFactory.java > 1528446 > > trunk/ql/src/java/org/apache/hadoop/hive/ql/optimizer/ppr/PartExprEvalUtils.java > 1528446 > > trunk/ql/src/java/org/apache/hadoop/hive/ql/optimizer/ppr/PartitionExpressionForMetastore.java > 1528446 > > trunk/ql/src/java/org/apache/hadoop/hive/ql/optimizer/ppr/PartitionPruner.java > 1528446 > trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java > 1528446 > trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/ExprNodeDescUtils.java > 1528446 > > trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/ExprNodeGenericFuncDesc.java > 1528446 > trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/TableScanDesc.java 1528446 > trunk/ql/src/java/org/apache/hadoop/hive/ql/ppd/ExprWalkerProcFactory.java > 1528446 > trunk/ql/src/java/org/apache/hadoop/hive/ql/ppd/OpProcFactory.java 1528446 > trunk/ql/src/test/org/apache/hadoop/hive/ql/exec/TestUtilities.java 1528446 > > trunk/ql/src/test/org/apache/hadoop/hive/ql/exec/vector/TestVectorSelectOperator.java > 1528446 > > trunk/ql/src/test/org/apache/hadoop/hive/ql/exec/vector/TestVectorizationContext.java > 1528446 > > trunk/ql/src/test/org/apache/hadoop/hive/ql/io/sarg/TestSearchArgumentImpl.java > 1528446 > trunk/ql/src/test/results/compiler/plan/case_sensitivity.q.xml 1528446 > trunk/ql/src/test/results/compiler/plan/cast1.q.xml 1528446 > trunk/ql/src/test/results/compiler/plan/groupby1.q.xml 1528446 > trunk/ql/src/test/results/compiler/plan/groupby2.q.xml 1528446 > trunk/ql/src/test/results/compiler/plan/groupby3.q.xml 1528446 > trunk/ql/src/test/results/compiler/plan/groupby4.q.xml 1528446 > trunk/ql/src/test/results/compiler/plan/groupby5.q.xml 1528446 > trunk/ql/src/test/results/compiler/plan/groupby6.q.xml 1528446 > trunk/ql/src/test/results/compiler/plan/input1.q.xml 1528446 > trunk/ql/src/test/results/compiler/plan/input2.q.xml 1528446 > trunk/ql/src/test/results/compiler/plan/input20.q.xml 1528446 > trunk/ql/src/test/results/compiler/plan/input3.q.xml 1528446 > trunk/ql/src/test/results/compiler/plan/input4.q.xml 1528446 > trunk/ql/src/test/results/compiler/plan/input6.q.xml 1528446 > trunk/ql/src/test/results/compiler/plan/input8.q.xml 1528446 > trunk/ql/src/test/results/compiler/plan/input9.q.xml 1528446 > trunk/ql/src/test/results/compiler/plan/input_part1.q.xml 1528446 > trunk/ql/src/test/results/compiler/plan/input_testxpath.q.xml 1528446 > trunk/ql/src/test/results/compiler/plan/input_testxpath2.q.xml 1528446 > trunk/ql/src/test/results/compiler/plan/join2.q.xml 1528446 > trunk/ql/src/test/results/compiler/plan/join4.q.xml 1528446 > trunk/ql/src/test/results/compiler/plan/join5.q.xml 1528446 > trunk/ql/src/test/results/compiler/plan/join6.q.xml 1528446 > trunk/ql/src/test/results/compiler/plan/join7.q.xml 1528446 > trunk/ql/src/test/results/compiler/plan/join8.q.xml 1528446 > trunk/ql/src/test/results/compiler/plan/sample1.q.xml 1528446 > trunk/ql/src/test/results/compiler/plan/sample2.q.xml 1528446 > trunk/ql/src/test/results/compiler/plan/sample3.q.xml 1528446 > trunk/ql/src/test/results/compiler/plan/sample4.q.xml 1528446 > trunk/ql/src/test/results/compiler/plan/sample5.q.xml 1528446 > trunk/ql/src/test/results/compiler/plan/sample6.q.xml 1528446 > trunk/ql/src/test/results/compiler/plan/sample7.q.xml 1528446 > trunk/ql/src/test/results/compiler/plan/subq.q.xml 1528446 > trunk/ql/src/test/results/compiler/plan/udf1.q.xml 1528446 > trunk/ql/src/test/results/compiler/plan/udf4.q.xml 1528446 > trunk/ql/src/test/results/compiler/plan/udf6.q.xml 1528446 > trunk/ql/src/test/results/compiler/plan/udf_case.q.xml 1528446 > trunk/ql/src/test/results/compiler/plan/udf_when.q.xml 1528446 > trunk/ql/src/test/results/compiler/plan/union.q.xml 1528446 > > Diff: https://reviews.apache.org/r/14428/diff/ > > > Testing > ------- > > No new functionality. Improvement of existing functionality. Existing test > case should suffice. > > > Thanks, > > Ashutosh Chauhan > >
