----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14428/#review26617 -----------------------------------------------------------
trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java <https://reviews.apache.org/r/14428/#comment51855> 10345... trunk/ql/src/java/org/apache/hadoop/hive/ql/ppd/OpProcFactory.java <https://reviews.apache.org/r/14428/#comment51856> the return type of the fn above has changed, this check seems useless trunk/ql/src/test/org/apache/hadoop/hive/ql/io/sarg/TestSearchArgumentImpl.java <https://reviews.apache.org/r/14428/#comment51857> why is this needed? if needed, please add exception listener (see XMLDecoder APIs) trunk/ql/src/test/org/apache/hadoop/hive/ql/io/sarg/TestSearchArgumentImpl.java <https://reviews.apache.org/r/14428/#comment51858> should this be removed? - Sergey Shelukhin On Oct. 2, 2013, 1:07 p.m., Ashutosh Chauhan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14428/ > ----------------------------------------------------------- > > (Updated Oct. 2, 2013, 1:07 p.m.) > > > Review request for hive. > > > Bugs: HIVE-5411 > https://issues.apache.org/jira/browse/HIVE-5411 > > > Repository: hive > > > Description > ------- > > Migrate expression serialization to Kryo > > > Diffs > ----- > > > trunk/hbase-handler/src/java/org/apache/hadoop/hive/hbase/HBaseStorageHandler.java > 1528446 > > trunk/hbase-handler/src/java/org/apache/hadoop/hive/hbase/HiveHBaseTableInputFormat.java > 1528446 > > trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/ExprNodeGenericFuncEvaluator.java > 1528446 > trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java 1528446 > > trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorizationContext.java > 1528446 > > trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/vector/udf/VectorUDFAdaptor.java > 1528446 > > trunk/ql/src/java/org/apache/hadoop/hive/ql/index/IndexPredicateAnalyzer.java > 1528446 > trunk/ql/src/java/org/apache/hadoop/hive/ql/index/IndexSearchCondition.java > 1528446 > > trunk/ql/src/java/org/apache/hadoop/hive/ql/index/compact/CompactIndexHandler.java > 1528446 > trunk/ql/src/java/org/apache/hadoop/hive/ql/io/HiveInputFormat.java 1528446 > trunk/ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java > 1528446 > trunk/ql/src/java/org/apache/hadoop/hive/ql/io/sarg/SearchArgument.java > 1528446 > trunk/ql/src/java/org/apache/hadoop/hive/ql/io/sarg/SearchArgumentImpl.java > 1528446 > trunk/ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 1528446 > > trunk/ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveStoragePredicateHandler.java > 1528446 > > trunk/ql/src/java/org/apache/hadoop/hive/ql/optimizer/index/RewriteCanApplyProcFactory.java > 1528446 > > trunk/ql/src/java/org/apache/hadoop/hive/ql/optimizer/pcr/PcrExprProcFactory.java > 1528446 > > trunk/ql/src/java/org/apache/hadoop/hive/ql/optimizer/ppr/PartExprEvalUtils.java > 1528446 > > trunk/ql/src/java/org/apache/hadoop/hive/ql/optimizer/ppr/PartitionExpressionForMetastore.java > 1528446 > > trunk/ql/src/java/org/apache/hadoop/hive/ql/optimizer/ppr/PartitionPruner.java > 1528446 > trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java > 1528446 > trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/ExprNodeDescUtils.java > 1528446 > > trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/ExprNodeGenericFuncDesc.java > 1528446 > trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/TableScanDesc.java 1528446 > trunk/ql/src/java/org/apache/hadoop/hive/ql/ppd/ExprWalkerProcFactory.java > 1528446 > trunk/ql/src/java/org/apache/hadoop/hive/ql/ppd/OpProcFactory.java 1528446 > trunk/ql/src/test/org/apache/hadoop/hive/ql/exec/TestUtilities.java 1528446 > > trunk/ql/src/test/org/apache/hadoop/hive/ql/exec/vector/TestVectorSelectOperator.java > 1528446 > > trunk/ql/src/test/org/apache/hadoop/hive/ql/exec/vector/TestVectorizationContext.java > 1528446 > > trunk/ql/src/test/org/apache/hadoop/hive/ql/io/sarg/TestSearchArgumentImpl.java > 1528446 > trunk/ql/src/test/results/compiler/plan/case_sensitivity.q.xml 1528446 > trunk/ql/src/test/results/compiler/plan/cast1.q.xml 1528446 > trunk/ql/src/test/results/compiler/plan/groupby1.q.xml 1528446 > trunk/ql/src/test/results/compiler/plan/groupby2.q.xml 1528446 > trunk/ql/src/test/results/compiler/plan/groupby3.q.xml 1528446 > trunk/ql/src/test/results/compiler/plan/groupby4.q.xml 1528446 > trunk/ql/src/test/results/compiler/plan/groupby5.q.xml 1528446 > trunk/ql/src/test/results/compiler/plan/groupby6.q.xml 1528446 > trunk/ql/src/test/results/compiler/plan/input1.q.xml 1528446 > trunk/ql/src/test/results/compiler/plan/input2.q.xml 1528446 > trunk/ql/src/test/results/compiler/plan/input20.q.xml 1528446 > trunk/ql/src/test/results/compiler/plan/input3.q.xml 1528446 > trunk/ql/src/test/results/compiler/plan/input4.q.xml 1528446 > trunk/ql/src/test/results/compiler/plan/input6.q.xml 1528446 > trunk/ql/src/test/results/compiler/plan/input8.q.xml 1528446 > trunk/ql/src/test/results/compiler/plan/input9.q.xml 1528446 > trunk/ql/src/test/results/compiler/plan/input_part1.q.xml 1528446 > trunk/ql/src/test/results/compiler/plan/input_testxpath.q.xml 1528446 > trunk/ql/src/test/results/compiler/plan/input_testxpath2.q.xml 1528446 > trunk/ql/src/test/results/compiler/plan/join2.q.xml 1528446 > trunk/ql/src/test/results/compiler/plan/join4.q.xml 1528446 > trunk/ql/src/test/results/compiler/plan/join5.q.xml 1528446 > trunk/ql/src/test/results/compiler/plan/join6.q.xml 1528446 > trunk/ql/src/test/results/compiler/plan/join7.q.xml 1528446 > trunk/ql/src/test/results/compiler/plan/join8.q.xml 1528446 > trunk/ql/src/test/results/compiler/plan/sample1.q.xml 1528446 > trunk/ql/src/test/results/compiler/plan/sample2.q.xml 1528446 > trunk/ql/src/test/results/compiler/plan/sample3.q.xml 1528446 > trunk/ql/src/test/results/compiler/plan/sample4.q.xml 1528446 > trunk/ql/src/test/results/compiler/plan/sample5.q.xml 1528446 > trunk/ql/src/test/results/compiler/plan/sample6.q.xml 1528446 > trunk/ql/src/test/results/compiler/plan/sample7.q.xml 1528446 > trunk/ql/src/test/results/compiler/plan/subq.q.xml 1528446 > trunk/ql/src/test/results/compiler/plan/udf1.q.xml 1528446 > trunk/ql/src/test/results/compiler/plan/udf4.q.xml 1528446 > trunk/ql/src/test/results/compiler/plan/udf6.q.xml 1528446 > trunk/ql/src/test/results/compiler/plan/udf_case.q.xml 1528446 > trunk/ql/src/test/results/compiler/plan/udf_when.q.xml 1528446 > trunk/ql/src/test/results/compiler/plan/union.q.xml 1528446 > > Diff: https://reviews.apache.org/r/14428/diff/ > > > Testing > ------- > > No new functionality. Improvement of existing functionality. Existing test > case should suffice. > > > Thanks, > > Ashutosh Chauhan > >
