[
https://issues.apache.org/jira/browse/HIVE-5395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13784030#comment-13784030
]
Brock Noland commented on HIVE-5395:
------------------------------------
First of all big thanks for doing these cleanups! Also +1
> Various cleanup in ptf code
> ---------------------------
>
> Key: HIVE-5395
> URL: https://issues.apache.org/jira/browse/HIVE-5395
> Project: Hive
> Issue Type: Improvement
> Reporter: Edward Capriolo
> Assignee: Edward Capriolo
> Attachments: HIVE-5395.1.patch.txt, HIVE-5395.2.patch.txt,
> HIVE-5395.3.patch.txt, HIVE-5395.4.patch.txt
>
>
> Some minor issues:
> Implementing classes on left side of equals
> Stack used instead of ArrayDeque
> Classes defined statically inside other files (when they do not need to be
> Checkstyle errors like indenting
--
This message was sent by Atlassian JIRA
(v6.1#6144)
