[ 
https://issues.apache.org/jira/browse/HIVE-5395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13780695#comment-13780695
 ] 

Hive QA commented on HIVE-5395:
-------------------------------



{color:red}Overall{color}: -1 no tests executed

Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12605625/HIVE-5395.1.patch.txt

Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/946/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/946/console

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.PrepPhase
Tests failed with: NonZeroExitCodeException: Command 'bash 
/data/hive-ptest/working/scratch/source-prep.sh' failed with exit status 1 and 
output '+ [[ -n '' ]]
+ export 'ANT_OPTS=-Xmx1g -XX:MaxPermSize=256m -Dhttp.proxyHost=localhost 
-Dhttp.proxyPort=3128'
+ ANT_OPTS='-Xmx1g -XX:MaxPermSize=256m -Dhttp.proxyHost=localhost 
-Dhttp.proxyPort=3128'
+ cd /data/hive-ptest/working/
+ tee /data/hive-ptest/logs/PreCommit-HIVE-Build-946/source-prep.txt
+ mkdir -p maven ivy
+ [[ svn = \s\v\n ]]
+ [[ -n '' ]]
+ [[ -d apache-svn-trunk-source ]]
+ [[ ! -d apache-svn-trunk-source/.svn ]]
+ [[ ! -d apache-svn-trunk-source ]]
+ cd apache-svn-trunk-source
+ svn revert -R .
++ egrep -v '^X|^Performing status on external'
++ awk '{print $2}'
++ svn status --no-ignore
+ rm -rf build hcatalog/build hcatalog/core/build 
hcatalog/storage-handlers/hbase/build hcatalog/server-extensions/build 
hcatalog/webhcat/svr/build hcatalog/webhcat/java-client/build 
hcatalog/hcatalog-pig-adapter/build common/src/gen
+ svn update
U    
hcatalog/core/src/test/java/org/apache/hcatalog/cli/DummyStorageHandler.java
U    
hcatalog/storage-handlers/hbase/src/java/org/apache/hcatalog/hbase/HBaseBaseOutputFormat.java
U    
hbase-handler/src/java/org/apache/hadoop/hive/hbase/HiveHFileOutputFormat.java
U    ql/src/test/org/apache/hadoop/hive/ql/io/udf/Rot13OutputFormat.java
U    ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestInputOutputFormat.java
U    ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java
U    ql/src/java/org/apache/hadoop/hive/ql/exec/persistence/PTFRowContainer.java
U    ql/src/java/org/apache/hadoop/hive/ql/exec/persistence/RowContainer.java
U    ql/src/java/org/apache/hadoop/hive/ql/exec/FileSinkOperator.java
U    ql/src/java/org/apache/hadoop/hive/ql/io/RCFileOutputFormat.java
A    ql/src/java/org/apache/hadoop/hive/ql/io/FSRecordWriter.java
U    ql/src/java/org/apache/hadoop/hive/ql/io/HiveIgnoreKeyTextOutputFormat.java
U    ql/src/java/org/apache/hadoop/hive/ql/io/HivePassThroughOutputFormat.java
U    ql/src/java/org/apache/hadoop/hive/ql/io/HivePassThroughRecordWriter.java
U    ql/src/java/org/apache/hadoop/hive/ql/io/HiveOutputFormat.java
U    ql/src/java/org/apache/hadoop/hive/ql/io/HiveBinaryOutputFormat.java
U    ql/src/java/org/apache/hadoop/hive/ql/io/orc/ReaderImpl.java
U    ql/src/java/org/apache/hadoop/hive/ql/io/orc/WriterImpl.java
U    ql/src/java/org/apache/hadoop/hive/ql/io/orc/Reader.java
U    ql/src/java/org/apache/hadoop/hive/ql/io/orc/Writer.java
U    ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcOutputFormat.java
U    
ql/src/java/org/apache/hadoop/hive/ql/io/HiveNullValueSequenceFileOutputFormat.java
U    ql/src/java/org/apache/hadoop/hive/ql/io/HiveSequenceFileOutputFormat.java
U    ql/src/java/org/apache/hadoop/hive/ql/io/HiveFileFormatUtils.java
U    ql/src/java/org/apache/hadoop/hive/ql/io/avro/AvroGenericRecordWriter.java
U    
ql/src/java/org/apache/hadoop/hive/ql/io/avro/AvroContainerOutputFormat.java
U    
contrib/src/java/org/apache/hadoop/hive/contrib/fileformat/base64/Base64TextOutputFormat.java
U    serde/src/java/org/apache/hadoop/hive/serde2/SerDeStats.java

Fetching external item into 'hcatalog/src/test/e2e/harness'
Updated external to revision 1527150.

Updated to revision 1527150.
+ patchCommandPath=/data/hive-ptest/working/scratch/smart-apply-patch.sh
+ patchFilePath=/data/hive-ptest/working/scratch/build.patch
+ [[ -f /data/hive-ptest/working/scratch/build.patch ]]
+ chmod +x /data/hive-ptest/working/scratch/smart-apply-patch.sh
+ /data/hive-ptest/working/scratch/smart-apply-patch.sh 
/data/hive-ptest/working/scratch/build.patch
The patch does not appear to apply with p0 to p2
+ exit 1
'
{noformat}

This message is automatically generated.
                
> Various cleanup in ptf code
> ---------------------------
>
>                 Key: HIVE-5395
>                 URL: https://issues.apache.org/jira/browse/HIVE-5395
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: Edward Capriolo
>            Assignee: Edward Capriolo
>         Attachments: HIVE-5395.1.patch.txt, HIVE-5395.2.patch.txt, 
> HIVE-5395.3.patch.txt
>
>
> Some minor issues:
> Implementing classes on left side of equals
> Stack used instead of ArrayDeque
> Classes defined statically inside other files (when they do not need to be
> Checkstyle errors like indenting

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to