[ https://issues.apache.org/jira/browse/HIVE-5366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13779612#comment-13779612 ]
Hudson commented on HIVE-5366: ------------------------------ FAILURE: Integrated in Hive-trunk-h0.21 #2361 (See [https://builds.apache.org/job/Hive-trunk-h0.21/2361/]) HIVE-5366 : Refactor a few object inspector class to eliminate redundant information (Xuefu Zhang via Ashutosh Chauhan) (hashutosh: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1526603) * /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/primitive/LazyHiveVarcharObjectInspector.java * /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/AbstractPrimitiveObjectInspector.java * /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/JavaHiveVarcharObjectInspector.java * /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/WritableHiveVarcharObjectInspector.java > Refactor a few object inspector class to eliminate redundant information > ------------------------------------------------------------------------ > > Key: HIVE-5366 > URL: https://issues.apache.org/jira/browse/HIVE-5366 > Project: Hive > Issue Type: Improvement > Components: Serializers/Deserializers, Types > Affects Versions: 0.12.0 > Reporter: Xuefu Zhang > Assignee: Xuefu Zhang > Fix For: 0.13.0 > > Attachments: HIVE-5366.patch > > > AbstractPrimitiveObjectInspector class has two fields: > {code} > protected PrimitiveTypeEntry typeEntry; > protected BaseTypeParams typeParams; > {code} > But PrimitiveTypeEntry already has member BaseTypeParams instance, which is > identical to "typeParams" we see here. Thus, there is some redundant > information stored at different places. Ideally, we should have a single > point of truth. > This refactoring is required by HIVE-3976 work. This is singled out to make > the review easier. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira