[
https://issues.apache.org/jira/browse/HIVE-5366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13778914#comment-13778914
]
Ashutosh Chauhan commented on HIVE-5366:
----------------------------------------
Btw, it seems there is also repetition of info between TypeInfo and TypeEntry
class hierarchies. It seems that some refactoring could be done there also to
streamline code. Certainly out of scope of this jira, but worth thinking about.
> Refactor a few object inspector class to eliminate redundant information
> ------------------------------------------------------------------------
>
> Key: HIVE-5366
> URL: https://issues.apache.org/jira/browse/HIVE-5366
> Project: Hive
> Issue Type: Improvement
> Components: Serializers/Deserializers, Types
> Affects Versions: 0.12.0
> Reporter: Xuefu Zhang
> Assignee: Xuefu Zhang
> Fix For: 0.13.0
>
> Attachments: HIVE-5366.patch
>
>
> AbstractPrimitiveObjectInspector class has two fields:
> {code}
> protected PrimitiveTypeEntry typeEntry;
> protected BaseTypeParams typeParams;
> {code}
> But PrimitiveTypeEntry already has member BaseTypeParams instance, which is
> identical to "typeParams" we see here. Thus, there is some redundant
> information stored at different places. Ideally, we should have a single
> point of truth.
> This refactoring is required by HIVE-3976 work. This is singled out to make
> the review easier.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
