[ 
https://issues.apache.org/jira/browse/HIVE-2870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13245489#comment-13245489
 ] 

Phabricator commented on HIVE-2870:
-----------------------------------

kevinwilfong has commented on the revision "HIVE-2870 [jira] Throw an error 
when a nonexistent partition is accessed in strict mode".

  Sorry, I should have been clearer earlier, by strict mode is set to false, I 
meant HIVE_ERROR_NO_VALID_PARTITIONS_LEFT is set to false.

  Also, could you add an entry to conf/hive-default.xml.template with your new 
variable.

  Finally, I'm sorry, I know I've been waffling on this point, but I think the 
way to go is to print a warning to the console if 
HIVE_ERROR_NO_VALID_PARTITIONS_LEFT is set to true (using 
SessionState.get().getConsole().printInfo()) and otherwise log it.  This way 
you can default it to true.

  To give you better context, my reasoning is that if an administrator sets the 
variable to false, users will be unlikely to set it to true, and if this might 
break valid queries, it would be difficult for administrators to justify 
setting it to true, so the error will probably not get used.  If you make it 
simply print a warning, it will not break queries, so the variable can be 
defaulted to true.  If the users have a valid query and are annoyed by the 
warning, they can turn it off using that variable, but the information won't 
totally be lost if you log it in that case.

REVISION DETAIL
  https://reviews.facebook.net/D2319

                
> Throw an error when a nonexistent partition is accessed in strict mode
> ----------------------------------------------------------------------
>
>                 Key: HIVE-2870
>                 URL: https://issues.apache.org/jira/browse/HIVE-2870
>             Project: Hive
>          Issue Type: Improvement
>          Components: Query Processor
>            Reporter: Lucian Adrian Grijincu
>            Priority: Minor
>         Attachments: HIVE-2870.D2319.1.patch, HIVE-2870.D2319.2.patch, 
> HIVE-2870.D2319.3.patch, HIVE-2870.D2319.4.patch, HIVE-2870.D2319.5.patch
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> When a table does not exist and someone tries to read from it in a query, 
> Hive throws an error.
> But if a partition is directly accessed that does not exist, an error is not 
> thrown. This is inconsistent and also leads to a lot of confused users who 
> get no output.
> This task is to cause Hive to throw an error when the partition pruner for a 
> query eliminates ALL existing partitions for some table when running in 
> strict mode.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to