[
https://issues.apache.org/jira/browse/HIVE-2870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13233844#comment-13233844
]
Phabricator commented on HIVE-2870:
-----------------------------------
kevinwilfong has commented on the revision "HIVE-2870 [jira] Throw an error
when a nonexistent partition is accessed in strict mode".
By a test case, I meant add a query to that list to test that the query
actually does fail if there are no partitions.
Also, it might be a good idea to add a test case in client positive to make
sure you can turn it off.
See
https://cwiki.apache.org/confluence/display/Hive/HowToContribute#HowToContribute-AddaUnitTest
INLINE COMMENTS
ql/src/java/org/apache/hadoop/hive/ql/optimizer/ppr/PartitionPruner.java:246-252
Sorry to be picky, but could you also add a small comment here just giving a
quick explanation of what it does.
REVISION DETAIL
https://reviews.facebook.net/D2319
> Throw an error when a nonexistent partition is accessed in strict mode
> ----------------------------------------------------------------------
>
> Key: HIVE-2870
> URL: https://issues.apache.org/jira/browse/HIVE-2870
> Project: Hive
> Issue Type: Improvement
> Components: Query Processor
> Reporter: Lucian Adrian Grijincu
> Priority: Minor
> Attachments: HIVE-2870.D2319.1.patch, HIVE-2870.D2319.2.patch
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> When a table does not exist and someone tries to read from it in a query,
> Hive throws an error.
> But if a partition is directly accessed that does not exist, an error is not
> thrown. This is inconsistent and also leads to a lot of confused users who
> get no output.
> This task is to cause Hive to throw an error when the partition pruner for a
> query eliminates ALL existing partitions for some table when running in
> strict mode.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
