On 1/23/24 10:10, Ayush Saxena wrote:
Ok I will get the repo deleted. I am not taking any sarcastic comments from Zoltan at this stage. Believe me I am not getting anything for having my name there.Why I did this?Someone was so obsessed with getting his name checked into the "Apache Code" that he developed something on his fork & checked in that code to the Apache Hive code, so, professional.
I don't aggree - as this is just not true! This project was created way-way back to aid my own efforts - didn't even looked like it will be used like this later. so I've created a separate repo - as there would have been not much reason to wait for approvals on tool changes only I use! I was using it for years - and when I was replacing the CI I've used it to get a good base ground for running the tests - as it could prepare a lot of things already. I had to do a lot of things - and the move of the repo was never at the top of the list... ...and it never proved to be a bottleneck; as you can just fork&upload a new image and reference that instead...
Many Hive Commiters have rights is a wrong phrase to quote: Many Hive Committer who are your friends have rights. To push an image we need to catch Zoltan, but ok do whatever you want.
That's not true either as you can see in a week-or-so old comment from me (https://github.com/kgyrtkirk/hive-dev-box/pull/15#issuecomment-1893414474) describing how you could push a new image and use that instead ; bypassing me entirely... The PR with that changed docker image to `wecharyu/hive-dev-box:executor` got merged a few days back...so as of now the hive ci doesn't have much connection to the original repo.
I just want to say, Zoltan, you might be a very good developer, but please change your "whatever you want to do" tone,
I think you went forward and done something before even writing a single line - or did I miss it?
Not following this further
have it your way! cheers, Zoltan
-Ayush On Tue, 23 Jan 2024 at 14:30, Zoltan Haindrich <k...@rxd.hu <mailto:k...@rxd.hu>> wrote: > I just copied the repo: cp -R and Put Zoltan's name & reference to his > repo. I didn't knew any better way than that, you can definitely force push > with another fancy approach lol...what a sophisticated approach - I wonder if you don't know the `fancy approach` then why you've done it? I wonder what you've copied - because you missed the addition of the github action which builds the image for every PR Now you are the sole contributor of all existing stuff (congrats)...but do whatever you want... It was always there and available to use - many hive commiters had push and approve rights on those repos. I think you might also want to do the same with https://github.com/kgyrtkirk/hive-toolbox <https://github.com/kgyrtkirk/hive-toolbox> because your contribution references it here: https://github.com/apache/hive-dev-box/blob/663625bc74e799f35c6bab1c1485530367287c61/tools/install_toolbox#L21C1-L21C115 <https://github.com/apache/hive-dev-box/blob/663625bc74e799f35c6bab1c1485530367287c61/tools/install_toolbox#L21C1-L21C115> and probably also cp -R https://github.com/kgyrtkirk/hive-test-kube/ <https://github.com/kgyrtkirk/hive-test-kube/> cheers, Zoltan On 1/23/24 09:29, Ayush Saxena wrote: > I just copied the repo: cp -R and Put Zoltan's name & reference to his > repo. I didn't knew any better way than that, you can definitely force push > with another fancy approach, just c-pick the other commits for NOTICE & all > on top of it. The old code & commits had some cloudera references, which I > personally wanted to avoid, but yep we can take another approach as well. > Good with me. > > For the Jira, yep we should, we aren't going to release this, so for fix > version, maybe I will create a dev-box-1.0.0 which we can use to resolve > the tickets, shouldn't put main repo versions, else that will pop up in our > release notes, or let me know if you want a separate Jira project under > Hive for these repos as well, We can explore that route if folks feel that > way. > > -Ayush > > > On Tue, 23 Jan 2024 at 13:35, Stamatis Zampetakis <zabe...@gmail.com <mailto:zabe...@gmail.com>> wrote: > >> Thanks for helping advance this Ayush! >> >> I saw that the commit history was not retained. Is there any reason >> for dropping it? Keeping the history and the people who contributed >> thus far would be nice to have. >> >> For the contribution model to this repository, I would recommend the >> usual process. Raise a JIRA ticket, file a PR, wait for review, and >> then merge. >> >> Best, >> Stamatis >> >> On Tue, Jan 23, 2024 at 8:45 AM Ayush Saxena <ayush...@gmail.com <mailto:ayush...@gmail.com>> wrote: >>> >>> This is the new repo: >>> https://github.com/apache/hive-dev-box <https://github.com/apache/hive-dev-box> >>> >>> It has the initial code from Zoltan, LICENSE, NOTICE & Disclaimer-WIP >>> file + I added Apache Header to all the files wherever possible. We need >> a >>> docker space to push these built images, have requested INFRA for the >> same. >>> >>> The repo is in WIP stage, If you find something problematic, please push >> a >>> fix to the repo or let me know. >>> >>> Some observations: >>> * The build command works on x86 box only not on aarch64, >>> * The github action to push the images doesn't work, that needs to be >> fixed >>> >>> -Ayush >>> >>> On Mon, 22 Jan 2024 at 21:55, Ayush Saxena <ayush...@gmail.com <mailto:ayush...@gmail.com>> wrote: >>> >>>> I think we are now not using Zoltan's repo. We are using a fork from a >>>> contributor in the hive code.[1], I will go ahead and create a repo >> under >>>> Apache Hive for hive-dev-box tomorrow & put the LICENSE, NOTICE & >>>> DISCLAIMER-WIP files in it, Then will take things from there, atleast >> it >>>> would be a starting point and all of us can take care of things from >> there >>>> slowly-slowly :-) >>>> >>>> Shout out, if anyone has objections around it. >>>> >>>> -Ayush >>>> >>>> >>>> [1] >>>> >> https://github.com/apache/hive/blob/1aeaff2057a2f4c241f8bcc53a2a529e6e7f45d4/Jenkinsfile#L124C44-L124C65 <https://github.com/apache/hive/blob/1aeaff2057a2f4c241f8bcc53a2a529e6e7f45d4/Jenkinsfile#L124C44-L124C65> >>>> >>>> On Wed, 6 Sept 2023 at 20:11, Stamatis Zampetakis <zabe...@gmail.com <mailto:zabe...@gmail.com>> >>>> wrote: >>>> >>>>> Based on the discussion under LEGAL-653, it seems that the only >>>>> requirement to migrate the repos under the Apache namespace is to >>>>> apply the AL2 license in the majority of the files in there. >>>>> >>>>> I am looking for volunteers so that we can review the existing code in >>>>> those repo and apply the AL2 license where possible. Depending on how >>>>> many people step up we can divide the work accordingly. >>>>> >>>>> It would be interesting to see if we can use RAT [1] to >>>>> automate/assist in this process. >>>>> >>>>> Best, >>>>> Stamatis >>>>> >>>>> [1] https://creadur.apache.org/rat/apache-rat-plugin/usage.html <https://creadur.apache.org/rat/apache-rat-plugin/usage.html> >>>>> >>>>> On Thu, Aug 24, 2023 at 11:05 AM Stamatis Zampetakis < >> zabe...@gmail.com <mailto:zabe...@gmail.com>> >>>>> wrote: >>>>>> >>>>>> For the licensing question, I just created LEGAL-653 [1]. >>>>>> >>>>>> [1] https://issues.apache.org/jira/browse/LEGAL-653 <https://issues.apache.org/jira/browse/LEGAL-653> >>>>>> >>>>>> On Thu, Aug 24, 2023 at 11:55 AM Stamatis Zampetakis < >> zabe...@gmail.com <mailto:zabe...@gmail.com>> >>>>> wrote: >>>>>>> >>>>>>> Creating the new repos should be kind of trivial. I think I will >> be >>>>>>> able to do it using https://selfserve.apache.org/ <https://selfserve.apache.org/>. >>>>>>> >>>>>>> Since this will bring quite a bit of code under the ASF I will >> wait a >>>>>>> couple of days till I create the new repos. >>>>>>> >>>>>>> Once this is done, I think we can simply push the content from >> the old >>>>>>> repos to the new ones. To avoid any kind of IP problems it would >> be >>>>>>> best if Zoltan does this step. >>>>>>> >>>>>>> One thing that we may need to be careful about is the licensing of >>>>>>> these repos. We are not going to make source releases from there >> but >>>>>>> since the code will be under the ASF namespace people will assume >> that >>>>>>> it is ASF licensed so they may start copy-pasting stuff from >> there. >>>>>>> >>>>>>> Is there anything preventing us from putting the code under the >> AL2 >>>>> license? >>>>>>> >>>>>>> Best, >>>>>>> Stamatis >>>>>>> >>>>>>> On Wed, Aug 23, 2023 at 6:14 PM Attila Turoczy >>>>>>> <aturo...@cloudera.com.invalid> wrote: >>>>>>>> >>>>>>>> Thank you, Stamatis! Also, Zoltan for the "donation" :) >>>>>>>> >>>>>>>> -Attila >>>>>>>> >>>>>>>> On Wed, Aug 23, 2023 at 4:53 PM Ayush Saxena < >> ayush...@gmail.com <mailto:ayush...@gmail.com>> >>>>> wrote: >>>>>>>> >>>>>>>>> +1, >>>>>>>>> Thanx Stamatis foe initiating this. This was something which >> was >>>>> in my >>>>>>>>> mind as well since long but couldn’t find time. >>>>>>>>> >>>>>>>>> -Ayush >>>>>>>>> >>>>>>>>>> On 23-Aug-2023, at 6:19 PM, Zoltan Haindrich <k...@rxd.hu <mailto:k...@rxd.hu>> >>>>> wrote: >>>>>>>>>> >>>>>>>>>> Hey Stamatis! >>>>>>>>>> >>>>>>>>>> I'm happy to donate these repos / help with the migration! >>>>>>>>>> I should have done it earlier - but it was never top >>>>> priority...thank >>>>>>>>> you for initiating it! >>>>>>>>>> >>>>>>>>>> cheers, >>>>>>>>>> Zoltan >>>>>>>>>> >>>>>>>>>>> On 8/23/23 14:00, Stamatis Zampetakis wrote: >>>>>>>>>>> Hi all, >>>>>>>>>>> Our precommit infrastructure uses code that resides in the >>>>> following >>>>>>>>> repos. >>>>>>>>>>> * https://github.com/kgyrtkirk/hive-test-kube <https://github.com/kgyrtkirk/hive-test-kube> >>>>>>>>>>> * https://github.com/kgyrtkirk/hive-toolbox <https://github.com/kgyrtkirk/hive-toolbox> >>>>>>>>>>> * https://github.com/kgyrtkirk/hive-dev-box <https://github.com/kgyrtkirk/hive-dev-box> >>>>>>>>>>> These are mainly maintained by Zoltán Haindrich who is >> always >>>>> helpful >>>>>>>>>>> and kind to investigate and resolve issues. >>>>>>>>>>> For facilitating contributions from the apache community >> and >>>>> also >>>>>>>>>>> removing some burden from Zoltan's shoulders it may be a >> good >>>>> time to >>>>>>>>>>> migrate those and put them under the apache namespace. >>>>>>>>>>> For the initial migration, we could have a straightforward >> 1 >>>>> to 1 >>>>>>>>>>> mapping as shown below: >>>>>>>>>>> * https://github.com/apache/hive-test-kube <https://github.com/apache/hive-test-kube> >>>>>>>>>>> * https://github.com/apache/hive-toolbox <https://github.com/apache/hive-toolbox> >>>>>>>>>>> * https://github.com/apache/hive-dev-box <https://github.com/apache/hive-dev-box> >>>>>>>>>>> How do you feel about this? >>>>>>>>>>> Best, >>>>>>>>>>> Stamatis >>>>>>>>> >>>>> >>>> >> >
OpenPGP_signature.asc
Description: OpenPGP digital signature
