[
https://issues.apache.org/jira/browse/HIVE-2720?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Phabricator updated HIVE-2720:
------------------------------
Attachment: HIVE-2720.D1299.3.patch
enis updated the revision "HIVE-2720 [jira] Merge MetaStoreListener and
HiveMetaHook interfaces".
Reviewers: JIRA, ashutoshc, heyongqiang, cwsteinbach
Applied review suggestions by Carl Steinbach.
- Renamesd onXXX methods to postXXX
- Instead of using MetaStoreEventListener, we now extend HiveMetaHook.
- Added hooks for all the methods in the metastore.
- fixed formatting on some lines
- Note that HiveMetaHook is an interface, and when we add new methods there,
the current implementors(hcat) will not compile, unless they add those
methods stubs.
However, to keep backwords compatibility, the methods in HiveMetaHookBase,
and
MetaStoreEventListenerAdapter are overriden.
- Tests are currently running.
REVISION DETAIL
https://reviews.facebook.net/D1299
AFFECTED FILES
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java
conf/hive-default.xml.template
hbase-handler/src/java/org/apache/hadoop/hive/hbase/HBaseStorageHandler.java
metastore/src/java/org/apache/hadoop/hive/metastore/AlterHandler.java
metastore/src/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java
metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaHook.java
metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaHookBase.java
metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java
metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreEventListener.java
metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreEventListenerAdapter.java
metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreUtils.java
metastore/src/java/org/apache/hadoop/hive/metastore/events/AddPartitionEvent.java
metastore/src/java/org/apache/hadoop/hive/metastore/events/AlterPartitionEvent.java
metastore/src/java/org/apache/hadoop/hive/metastore/events/AlterTableEvent.java
metastore/src/java/org/apache/hadoop/hive/metastore/events/CreateDatabaseEvent.java
metastore/src/java/org/apache/hadoop/hive/metastore/events/CreateTableEvent.java
metastore/src/java/org/apache/hadoop/hive/metastore/events/DropDatabaseEvent.java
metastore/src/java/org/apache/hadoop/hive/metastore/events/DropPartitionEvent.java
metastore/src/java/org/apache/hadoop/hive/metastore/events/DropTableEvent.java
metastore/src/java/org/apache/hadoop/hive/metastore/events/ListenerEvent.java
metastore/src/java/org/apache/hadoop/hive/metastore/events/LoadPartitionDoneEvent.java
ql/src/java/org/apache/hadoop/hive/ql/metadata/DefaultStorageHandler.java
> Merge MetaStoreListener and HiveMetaHook interfaces
> ---------------------------------------------------
>
> Key: HIVE-2720
> URL: https://issues.apache.org/jira/browse/HIVE-2720
> Project: Hive
> Issue Type: Sub-task
> Components: JDBC, Metastore, ODBC, Security
> Reporter: Enis Soztutar
> Assignee: Enis Soztutar
> Attachments: HIVE-2720.D1299.1.patch, HIVE-2720.D1299.2.patch,
> HIVE-2720.D1299.3.patch
>
>
> MetaStoreListener and HiveMetaHook both serve as a notification mechanism for
> metastore-related events. The former is used by hcat and the latter is by the
> hbase-storage handler, and invoked by the client.
> I propose to merge these interfaces, and extend the MetaStoreListener, to add
> most of the on- and pre- methods at the Thrift interface. This way, extending
> metastore will be easier, and validation, storage-driver notification, and
> enforcement can be delegated to individual listeners. Besides, more
> functionality can be plugged-in by Hcat at this level.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
