[
https://issues.apache.org/jira/browse/HIVE-2720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13188328#comment-13188328
]
Phabricator commented on HIVE-2720:
-----------------------------------
cwsteinbach has requested changes to the revision "HIVE-2720 [jira] Merge
MetaStoreListener and HiveMetaHook interfaces".
INLINE COMMENTS
metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreEventListener.java:105
Are the onXXXX methods called after a metastore operation has been
successfully committed? If so should the name be changed to postXXX to make
this clear? What happens if an onXXX method throws an exception?
I assume that preXXX methods can block operations by throwing exceptions. If
that's accurate this should be explained in the javadoc.
Also, if these methods can do more than just listen, e.g. act, then I think
the name of this interface needs to be changed to make that clear.
ql/src/java/org/apache/hadoop/hive/ql/metadata/DefaultStorageHandler.java:83
Formatting. The same error is repeated elsewhere.
metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreEventListener.java:199
A bunch of these methods don't appear to be hooked up yet.
REVISION DETAIL
https://reviews.facebook.net/D1299
> Merge MetaStoreListener and HiveMetaHook interfaces
> ---------------------------------------------------
>
> Key: HIVE-2720
> URL: https://issues.apache.org/jira/browse/HIVE-2720
> Project: Hive
> Issue Type: Sub-task
> Components: JDBC, Metastore, ODBC, Security
> Reporter: Enis Soztutar
> Assignee: Enis Soztutar
> Attachments: HIVE-2720.D1299.1.patch, HIVE-2720.D1299.2.patch
>
>
> MetaStoreListener and HiveMetaHook both serve as a notification mechanism for
> metastore-related events. The former is used by hcat and the latter is by the
> hbase-storage handler, and invoked by the client.
> I propose to merge these interfaces, and extend the MetaStoreListener, to add
> most of the on- and pre- methods at the Thrift interface. This way, extending
> metastore will be easier, and validation, storage-driver notification, and
> enforcement can be delegated to individual listeners. Besides, more
> functionality can be plugged-in by Hcat at this level.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
