-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72503/
-----------------------------------------------------------

(Updated May 13, 2020, 2:28 a.m.)


Review request for hive and Ashutosh Chauhan.


Changes
-------

Addressed review comments and fixed TestContainerRunnerImpl


Repository: hive-git


Description
-------

For short jobs, submitWork() becomes hotpath. Patch tries to lazy load conf 
creation and also gets rid of dir creations (which needs to be enabled only 
when DirWatcher is enabled in ShuffleHandler)


Diffs (updated)
-----

  
llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/ContainerRunnerImpl.java
 6a13b55e69 
  
llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/QueryTracker.java 
eae8e08540 
  
llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/TaskRunnerCallable.java
 36192520e3 
  
llap-server/src/java/org/apache/hadoop/hive/llap/shufflehandler/ShuffleHandler.java
 aff2c2ec39 
  
llap-server/src/test/org/apache/hadoop/hive/llap/daemon/impl/TaskExecutorTestHelpers.java
 50dec4759e 
  
llap-server/src/test/org/apache/hadoop/hive/llap/daemon/impl/TestContainerRunnerImpl.java
 8ae00b9c87 


Diff: https://reviews.apache.org/r/72503/diff/2/

Changes: https://reviews.apache.org/r/72503/diff/1-2/


Testing
-------


File Attachments (updated)
----------------

HIVE-23449.2.patch
  
https://reviews.apache.org/media/uploaded/files/2020/05/13/36724ea5-265e-4e61-98a4-18af913b5b48__HIVE-23449.2.patch


Thanks,

Rajesh Balamohan

Reply via email to