> On May 13, 2020, 12:40 a.m., Ashutosh Chauhan wrote: > > llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/TaskRunnerCallable.java > > Line 257 (original), 259 (patched) > > <https://reviews.apache.org/r/72503/diff/1/?file=2231471#file2231471line259> > > > > I am not sure how memoization helps here. This conf.get() will always > > be called for this task execution. So, we might as well pass in conf here. > > Is there something we are saving by memoization?
This is to avoid re-evaluation in callInternal twice. But ideally, it could be avoided by getting its reference once in callInternal. Will revise it in next patch. - Rajesh ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72503/#review220729 ----------------------------------------------------------- On May 12, 2020, 9:59 p.m., Rajesh Balamohan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72503/ > ----------------------------------------------------------- > > (Updated May 12, 2020, 9:59 p.m.) > > > Review request for hive and Ashutosh Chauhan. > > > Repository: hive-git > > > Description > ------- > > For short jobs, submitWork() becomes hotpath. Patch tries to lazy load conf > creation and also gets rid of dir creations (which needs to be enabled only > when DirWatcher is enabled in ShuffleHandler) > > > Diffs > ----- > > > llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/ContainerRunnerImpl.java > 6a13b55e69 > > llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/QueryTracker.java > eae8e08540 > > llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/TaskRunnerCallable.java > 36192520e3 > > llap-server/src/java/org/apache/hadoop/hive/llap/shufflehandler/ShuffleHandler.java > aff2c2ec39 > > llap-server/src/test/org/apache/hadoop/hive/llap/daemon/impl/TaskExecutorTestHelpers.java > 50dec4759e > > > Diff: https://reviews.apache.org/r/72503/diff/1/ > > > Testing > ------- > > > Thanks, > > Rajesh Balamohan > >
