> On April 3, 2020, 9:59 a.m., Peter Vary wrote: > > standalone-metastore/metastore-tools/tools-common/src/main/java/org/apache/hadoop/hive/metastore/tools/HMSClient.java > > Lines 341 (patched) > > <https://reviews.apache.org/r/72112/diff/1/?file=2210963#file2210963line350> > > > > I put this in the code with HIVE-23042: > > boolean openTxn(int numTxns) throws TException { > > client.open_txns(new OpenTxnRequest(numTxns, "Test", "Host")); > > return true; > > } > > > > Maybe merge those?
The main difference between our two implementations of openTxn is that mine automatically returns the opened txn's id, in your version there has to be an additional getOpenTxns() call made to get the Id. Not sure if getOpenTxns would return some other ids that belong to an other client when multiple threads are used, o sI might be misunderstanding the getOpenTxns() call. What do you think? - Zoltan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72112/#review220212 ----------------------------------------------------------- On April 2, 2020, 2:13 p.m., Zoltan Chovan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72112/ > ----------------------------------------------------------- > > (Updated April 2, 2020, 2:13 p.m.) > > > Review request for hive, Denys Kuzmenko, Aron Hamvas, Marton Bod, and Peter > Vary. > > > Repository: hive-git > > > Description > ------- > > Add the possibility to run benchmarks on opening lock in the HMS. Currently > this change only introduces single-threaded/single client testing. I'm > planning to add multi-client support in a separate change. > > Example parametrisation is as follows: > hbench -M "lock" -N 10 -d hive_test -W 0 -L 100 > hbench -M ".*Lock.*" -N 10 -d hive_test -W 0 -L 100 -T 8 --params 100 > > This will create N number (10) of tables to lock and it'll execute the lock() > for L number (100) of times on T (8) threads where each thread will strart an > HMS client > > > Diffs > ----- > > > standalone-metastore/metastore-tools/metastore-benchmarks/src/main/java/org/apache/hadoop/hive/metastore/tools/BenchmarkTool.java > 041cd76234 > > standalone-metastore/metastore-tools/metastore-benchmarks/src/main/java/org/apache/hadoop/hive/metastore/tools/HMSBenchmarks.java > f53f2ef43b > > standalone-metastore/metastore-tools/tools-common/src/main/java/org/apache/hadoop/hive/metastore/tools/HMSClient.java > 7cc1e42a8b > > standalone-metastore/metastore-tools/tools-common/src/main/java/org/apache/hadoop/hive/metastore/tools/Util.java > 101d6759c5 > > > Diff: https://reviews.apache.org/r/72112/diff/1/ > > > Testing > ------- > > > File Attachments > ---------------- > > HIVE-22869.2.patch > > https://reviews.apache.org/media/uploaded/files/2020/04/02/5e35e835-f383-495f-9964-e66773fd6a90__HIVE-22869.2.patch > > > Thanks, > > Zoltan Chovan > >
