----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72112/#review220213 -----------------------------------------------------------
standalone-metastore/metastore-tools/metastore-benchmarks/src/main/java/org/apache/hadoop/hive/metastore/tools/HMSBenchmarks.java Lines 410 (patched) <https://reviews.apache.org/r/72112/#comment308527> Do you really need to have physical tables? standalone-metastore/metastore-tools/metastore-benchmarks/src/main/java/org/apache/hadoop/hive/metastore/tools/HMSBenchmarks.java Lines 414 (patched) <https://reviews.apache.org/r/72112/#comment308526> I think more realistic scenario is having up to 10 tables with 10-1000 (configurable) partitions and locking not only on table level but partition. standalone-metastore/metastore-tools/metastore-benchmarks/src/main/java/org/apache/hadoop/hive/metastore/tools/HMSBenchmarks.java Lines 422 (patched) <https://reviews.apache.org/r/72112/#comment308529> I think, for more realistic scenario we should move commit inside of bench + add some sleep to simulate query execution. Currently locks number is just keep increasing and could go very high that shouldn't happen in real system. standalone-metastore/metastore-tools/metastore-benchmarks/src/main/java/org/apache/hadoop/hive/metastore/tools/HMSBenchmarks.java Lines 467 (patched) <https://reviews.apache.org/r/72112/#comment308531> This lock builder looks overcomplicated. To create Lock request it's enough to : LockRequest req = new LockRequest(lockComponents, user, InetAddress.getLocalHost().getHostName()); req.setTxnid(txnId); standalone-metastore/metastore-tools/tools-common/src/main/java/org/apache/hadoop/hive/metastore/tools/HMSClient.java Lines 455 (patched) <https://reviews.apache.org/r/72112/#comment308530> Should we care about replPolicy here? - Denys Kuzmenko On April 2, 2020, 2:13 p.m., Zoltan Chovan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72112/ > ----------------------------------------------------------- > > (Updated April 2, 2020, 2:13 p.m.) > > > Review request for hive, Denys Kuzmenko, Aron Hamvas, Marton Bod, and Peter > Vary. > > > Repository: hive-git > > > Description > ------- > > Add the possibility to run benchmarks on opening lock in the HMS. Currently > this change only introduces single-threaded/single client testing. I'm > planning to add multi-client support in a separate change. > > Example parametrisation is as follows: > hbench -M "lock" -N 10 -d hive_test -W 0 -L 100 > hbench -M ".*Lock.*" -N 10 -d hive_test -W 0 -L 100 -T 8 --params 100 > > This will create N number (10) of tables to lock and it'll execute the lock() > for L number (100) of times on T (8) threads where each thread will strart an > HMS client > > > Diffs > ----- > > > standalone-metastore/metastore-tools/metastore-benchmarks/src/main/java/org/apache/hadoop/hive/metastore/tools/BenchmarkTool.java > 041cd76234 > > standalone-metastore/metastore-tools/metastore-benchmarks/src/main/java/org/apache/hadoop/hive/metastore/tools/HMSBenchmarks.java > f53f2ef43b > > standalone-metastore/metastore-tools/tools-common/src/main/java/org/apache/hadoop/hive/metastore/tools/HMSClient.java > 7cc1e42a8b > > standalone-metastore/metastore-tools/tools-common/src/main/java/org/apache/hadoop/hive/metastore/tools/Util.java > 101d6759c5 > > > Diff: https://reviews.apache.org/r/72112/diff/1/ > > > Testing > ------- > > > File Attachments > ---------------- > > HIVE-22869.2.patch > > https://reviews.apache.org/media/uploaded/files/2020/04/02/5e35e835-f383-495f-9964-e66773fd6a90__HIVE-22869.2.patch > > > Thanks, > > Zoltan Chovan > >
