> On ápr. 1, 2020, 7:38 de, Denys Kuzmenko wrote: > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java > > Lines 4295 (patched) > > <https://reviews.apache.org/r/72290/diff/1/?file=2216627#file2216627line4335> > > > > Please extract this into > > org.apache.hadoop.hive.metastore.tools.SQLGenerator > > Marton Bod wrote: > as discussed, let's move it to TxnDbUtil
Do we want to repurpose TxnDbUtil? What will be the method to decide if something is in SQLGenerator, or TxnDbUtil? Also TxnDbUtil class comment is this, we might want to fix this, if we change the usage pattern :) /** * Utility methods for creating and destroying txn database/schema, plus methods for * querying against metastore tables. * Placed here in a separate class so it can be shared across unit tests. */ - Peter ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72290/#review220164 ----------------------------------------------------------- On ápr. 1, 2020, 6:53 de, Marton Bod wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72290/ > ----------------------------------------------------------- > > (Updated ápr. 1, 2020, 6:53 de) > > > Review request for hive, Denys Kuzmenko and Peter Vary. > > > Repository: hive-git > > > Description > ------- > > HIVE-23067: Use batch DB calls in TxnHandler for commitTxn and abortTxns > > > Diffs > ----- > > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnDbUtil.java > ef88240a79 > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java > 74ef88545e > > > Diff: https://reviews.apache.org/r/72290/diff/3/ > > > Testing > ------- > > Green build: https://builds.apache.org/job/PreCommit-HIVE-Build/21347/ > > > Thanks, > > Marton Bod > >
