> On April 1, 2020, 7:38 a.m., Denys Kuzmenko wrote: > > LGTM, just a few comments.
Thanks for the review! > On April 1, 2020, 7:38 a.m., Denys Kuzmenko wrote: > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java > > Line 1300 (original), 1305 (patched) > > <https://reviews.apache.org/r/72290/diff/1/?file=2216627#file2216627line1306> > > > > Use setLong, setObject would require type inference sure > On April 1, 2020, 7:38 a.m., Denys Kuzmenko wrote: > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java > > Lines 1390 (patched) > > <https://reviews.apache.org/r/72290/diff/1/?file=2216627#file2216627line1421> > > > > Not 100% sure, I think Laci P was working on removal of > > MIN_HISTORY_LEVEL table (HIVE-23107), please check with him. yes he is, I will rebase onto his change once it's committed > On April 1, 2020, 7:38 a.m., Denys Kuzmenko wrote: > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java > > Lines 4295 (patched) > > <https://reviews.apache.org/r/72290/diff/1/?file=2216627#file2216627line4335> > > > > Please extract this into > > org.apache.hadoop.hive.metastore.tools.SQLGenerator as discussed, let's move it to TxnDbUtil - Marton ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72290/#review220164 ----------------------------------------------------------- On April 1, 2020, 6:53 a.m., Marton Bod wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72290/ > ----------------------------------------------------------- > > (Updated April 1, 2020, 6:53 a.m.) > > > Review request for hive, Denys Kuzmenko and Peter Vary. > > > Repository: hive-git > > > Description > ------- > > HIVE-23067: Use batch DB calls in TxnHandler for commitTxn and abortTxns > > > Diffs > ----- > > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java > 74ef88545e > > > Diff: https://reviews.apache.org/r/72290/diff/1/ > > > Testing > ------- > > Green build: https://builds.apache.org/job/PreCommit-HIVE-Build/21347/ > > > Thanks, > > Marton Bod > >
