----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71506/#review217910 -----------------------------------------------------------
Thanks Laszlo! Few quick questions below. We might want to test the cross exchange methods as well (exchange partition between temp and non-temp tables) Otherwise LGTM ql/src/java/org/apache/hadoop/hive/ql/metadata/SessionHiveMetaStoreClient.java Lines 1580 (patched) <https://reviews.apache.org/r/71506/#comment305286> What is the error message when we want to exchange partition between a temp table and a normal table? Maybe we want to have a specific error message instead? ql/src/java/org/apache/hadoop/hive/ql/metadata/SessionHiveMetaStoreClient.java Lines 1601 (patched) <https://reviews.apache.org/r/71506/#comment305287> What is the error message when we want to exchange partition between a temp table and a normal table? Maybe we want to have a specific error message instead? ql/src/java/org/apache/hadoop/hive/ql/metadata/SessionHiveMetaStoreClient.java Lines 1652-1653 (patched) <https://reviews.apache.org/r/71506/#comment305288> Why are we doing it in 2 steps? - Peter Vary On szept. 18, 2019, 2:10 du, Laszlo Pinter wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71506/ > ----------------------------------------------------------- > > (Updated szept. 18, 2019, 2:10 du) > > > Review request for hive, Marta Kuczora, Peter Vary, and Adam Szita. > > > Repository: hive-git > > > Description > ------- > > HIVE-22084: Implement exchange partitions related methods on temporary tables. > > > Diffs > ----- > > > ql/src/java/org/apache/hadoop/hive/ql/metadata/SessionHiveMetaStoreClient.java > 506bf5dfa8404f3645b8c5db7ea19c0b4add33a7 > > ql/src/test/org/apache/hadoop/hive/ql/metadata/TestSessionHiveMetastoreClientExchangePartitionsTempTable.java > PRE-CREATION > > standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/client/TestExchangePartitions.java > 1a2b7e4f9f7562e84006e86061b482d1b535197c > > > Diff: https://reviews.apache.org/r/71506/diff/3/ > > > Testing > ------- > > > Thanks, > > Laszlo Pinter > >
